upstream fixes #434

Closed

wowario wants to merge 527 commits from wowario:upstream23 into master

wowario commented

Owner

upstream fixes.. does not include multisig fixes nor view tags. They will be added to rebase later.

wowario added 89 commits

872df6eaf7

miniupnp: set submodule to upstream, disable install

f3c3d4108b

easylogging++: fix missing logs

a09d094d8d

support cors wildcard

8371d7dbba

simplewallet: don't truncate integ. address in export_transfers

3c1dea6f62

RPC and ZeroMQ APIs to support p2pool

Adds the following:

- "get_miner_data" to RPC API
- "json-miner-data" to ZeroMQ subscriber contexts

Both provide the necessary data to create a custom block template. They are used by p2pool.

Data provided:

- major fork version
- current height
- previous block id
- RandomX seed hash
- network difficulty
- median block weight
- coins mined by the network so far
- mineable mempool transactions

d008f54cdd

workflows: add missing dependency, fix mac build

3cdf6d6616

node_server: add race condition demo

074fc09f53

node_server: fix race condition

ecfdae7e13

rpc: Fix get_transactions failing when not found

9540565761

gitian: omit ccache from gitian builds

It's just wasted overhead since the build VMs are always deleted
and recreated fresh for each run.

6ae02a84bb

gitian: cleanup more unused packages

These appear to be leftovers inherited from Bitcoin's builder

ebefab6b2e

Quicker resource cleanup on p2p socks timeout

3d8ad564f8

Fix precision of average_output_time

The fix as suggested by <jberman> on IRC. Before the fix, it would truncate 1.9 to 1 skewing the output selection.

fe41c18266

LMDB: protection against UB, by not calling virtual methods from destructor - v0.17

8e9a4aed7a

UB: virtual method in destructor of WalletImpl v0.17

bac6090688

UB: virtual methods in destructor at Trezor

5498a66a5b

Decrease the "recent spend window" in gamma re-select to 15 blocks

- combined with patching integer truncation (#7798), this gets the algorithm marginally closer to mirroring empirically observed output ages
- 50 was originally chosen assuming integer truncation would remain in the client for that client release version. But patching integer truncation causes the client to select more outputs in the 10-100 block range, and therefore the benefit of choosing a larger recent spend window of 50 has less merit
- 15 seems well-suited to cover the somewhat sizable observable gap in the early window of blocks

606184f9f3

socks: ignore any exceptions in shutdown/close

ed67eb1b1f

protocol: fix spurious rejection of downloaded blocks

when kicking a peer for inactivity, clear the set of requested blocks,
or next time we requests blocks from it, we'll probably reject the
incoming blocks due to missing the previous requested blocks

f75495d7d7

wallet2: fix key encryption when changing ask-password from 0/1 to 2

we reuse the wallet_keys_unlocker object, which does the right thing
in conjunction with other users of decrypt/encrypt (ie, refresh).

879ab141e8

wallet2: chunk get_outs.bin calls to avoid sanity limits

5ba5c9952a

bootstrap_daemon: proxy configuration support

1c25e592f4

daemon: allow proxy configuration

Co-authored-by: selsta <selsta@sent.at>
Co-authored-by: tobtoht <thotbot@protonmail.com>

c53ea6e8e1

Mac: Enable on ARM, by not enforcing x86_64

117cd32ec1

epee: don't log raw packet data

a56c95f4b9

Only INFO log for short seed words with ALLOW_SHORT_WORDS active

0ddc2ace47

depends: update unwind, fix build with ubuntu 21.04

68136e3dbc

Fix parallel make of OpenSSL

7b5ab2bc16

cmake: set required C/C++ standard to 11

Co-authored-by: Jason Rhinelander <jason@imaginary.ca>

ed383f2923

blockchain: fix pedantic assert

ecaf74c511

LMDB: fix deadlock in resized detection

66046226fe

fix median overflow bug

f6c0e5cd6a

cmake: set cpp14 standard

It's 2021, we can easily switch to C++14 without any troubles.

f01873bfc9

epee: avoid ADL selecting C++14 std::quoted

4dde86656d

cmake: use CMAKE_CURRENT_LIST_DIR for git version

3a3acacc64

depends: update zeromq package to 4.3.4

e8b057302f

wallet_api: enable set_strict_default_file_permissions

cc35ef596f

depends: openssl 1.1.1k -> 1.1.1l

a4b7b32027

device: Ledger - update status codes

0882e82777

device: fix ledger error strings, add human friendly messages

6537bc4c47

hidapi: bump hidapi to 0.11.0

ac1607df5b

Add calcpow RPC

Calculate PoW hash for a block candidate

282eee8e09

rpc: fix DoS vector in get_output_distribution

This will prevent people spending old pre-rct outputs using a
stranger's node, which may be a good thing

9ee528bacc

Add simple script for running gitian-build

This shell script creates a docker image for running the gitian-build.py
script, to avoid version incompatibilities. The builds may be signed
automatically after manually reviewing the build hashes.

Only docker.io and apt-cacher-ng are required to be installed on the
host. The MacOSX SDK should also be present in this directory if Mac
builds are desired. A container named "gitrun" is used to launch
the builds, and all output will reside in this container as well.

0759cbb70b

cmake: set 3.5 as minimum version

a041884ba3

Fix Android OpenSSL build

depends didn't have target-specific overrides for _build_env
so ANDROID_NDK_HOME wasn't being set at build time.
This fix supersedes the manual edit of Configuration/15-android.conf.
Resolves #8095

4950c8e493

wallet inits cache if file and blob missing

93d8486662

Balance includes unconfirmed payments

baeda6df0e

Balance includes unconfirmed transfers to self

b6b74583f5

multisig key exchange update and refactor

2e2b7a7c0d

support authentication in monero-wallet-rpc set_daemon

31ef66ce77

simplewallet: rename duplicate amount headers for clarity

There are duplicate headers for 'amount' when performing export_transfers
all. Column five represents the total amount of the transaction while
column eleven represents the amount transferred per destination (e.g.
multi-destination transactions). The columns have been renamed to
'transaction amount' and 'destination amount` respectively.

c2a2678f39

[release-v0.17] Don't require --rpc-login with --rpc-access-control-origins

Same as PR #8187 for release v0.17

b6d6baa3a1

Added support for Ledger Nano S Plus

8fa3b2bc52

add a sanity check to RPC input data size

reported by m31007

0035b615f7

Remove serialization/enableable

Currently working on an EPEE [ser/de]ialization library for Rust and at first glance, EPEE seemed to have support for optional wrappers. However, after looking into it, this feature appears to be half-baked and unused. Furthermore, adding support for optional values would be better suited to implement at the storage level, in my opinion. That would make parsing DOMs easier and less error-prone. If anyone is currently using this code, please comment. Thanks!

At the time of writing, this PR has no merge conflicts with #8211

da6f819534

multisig: add post-kex verification round to check that all participants have completed the multisig address

a04207660d

Fix typo: SERIALIZE_TYPE_DUOBLE

20c8e31af3

CMake: Add missing BUILD_SHARED_LIBS option

ec5c163b34

Optimized keccak implementation

All tests were conducted on the same PC (Ryzen 5 5600X running at fixed 4.65 GHz).

Before:
test_cn_fast_hash<32> (100000 calls) - OK: 1 us/call
test_cn_fast_hash<16384> (1000 calls) - OK: 164 us/call

After:
test_cn_fast_hash<32> (100000 calls) - OK: 0 us/call
test_cn_fast_hash<16384> (1000 calls) - OK: 31 us/call

More than 5 times speedup for cn_fast_hash.

Also noticed consistent 1-2% improvement in test_construct_tx results.

619647f493

Preserve commitment format inside transactions

0d4cde3f3f

EPEE: Remove hmac-md5

17949581a7

EPEE: Remove gzip_encoding.h

16bd593720

refactor(bp+): save one inversion, use sc_muladd

aae0219ba6

Doxygen: Hide anonymous namespaces from documentation by default

Bonus: little doc fix for net_ssl.h

d0b1c21683

wallet2: fix a couple unused variable warnings

aeeb7fb5ca

Chunk /gettransactions to avoid hitting restricted RPC limit

1c295a849e

simplewallet: print usage when given no args

8840fecce1

wallet2: remove obsolete rpc version check

3f12ca0032

wallet2: keep around transaction prefix for confirmed transfers

bd704f9373

wallet2: force using output distribution for ringct outs

Co-authored-by: j-berman <justinberman@protonmail.com>

b3712657ce

Template hash func to fix compiler error on < gcc-6

cee6405708

Fix use of rtxn without a mdb_txn_safe wrapper

c62a648a08

Fixed get_block_template_backlog performance

Before the fix, it processed all transactions in the mempool which could be very slow when mempool grows to several MBs in size. I observed `get_block_template_backlog` taking up to 15 seconds of CPU time under high mempool load.

After the fix, only transactions that can potentially be mined in the next block will be processed (a bit more than the current block median weight).

537a2a761e

continue pool pruning even if a tx can't be found

5e2bc401ca

rpc: skip bootstrap nodes that are lower than last checkpoint

26defe5aea

Fix missing semi-colon in error message

Co-authored-by: woodser <woodser@protonmail.com>

ff0531cd02

Move update_checkpoints() to a later stage

update_checkpoints() makes a few DNS requests and can take up to 20-30 seconds to complete (3-6 seconds on average). It is currently called from core::handle_incoming_block() which holds m_incoming_tx_lock, so it blocks all incoming transactions and blocks processing while update_checkpoints() is running. This PR moves it to until after a new block has been processed and relayed, to avoid full monerod locking.

56cda7015a

Fix dandelion++ fluff/stem bug with local txes

4ecf632a1c

Fix static builds for Ubuntu 22.04

Link libbsd, libmd, libprotokit for ZMQ to fix static builds for Ubuntu 22.04

43e0119fb4

blockchain_prune: faster

on my anecdotal SSD, goes from about 9 hours to 1h20.

0fc81c249e

fix build in netbsd

a6fc8392c9

rpc: remove overwriting value

64d851c1e8

Remove redundant check

c8cc1e286d

Wallet RPC: remove duplicate line

c6d1002c05

update miniupnp

980c53c393

update RandomWOW

5d269a51f1

remove testnet from diff

7e50a782fd

remove extra WALLET_RPC_VERSION_MINOR

wowario closed this pull request

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wownero/wownero#434