UB: virtual method in destructor of WalletImpl v0.17

pull/434/head
mj-xmr 3 years ago committed by wowario
parent fe41c18266
commit 8e9a4aed7a
No known key found for this signature in database
GPG Key ID: 24DCBE762DE9C111

@ -447,7 +447,7 @@ WalletImpl::~WalletImpl()
LOG_PRINT_L1(__FUNCTION__);
m_wallet->callback(NULL);
// Pause refresh thread - prevents refresh from starting again
pauseRefresh();
WalletImpl::pauseRefresh(); // Call the method directly (not polymorphically) to protect against UB in destructor.
// Close wallet - stores cache and stops ongoing refresh operation
close(false); // do not store wallet as part of the closing activities
// Stop refresh thread

Loading…
Cancel
Save