5177 Commits (8e60b81c48f68a2ecd8aa3cc116ae3c7b7065fef)

 

All Branches   

Search

Author	SHA1	Message	Date
moneromooo-monero	8e60b81c48	cryptonote_core: fix db leak on error	7 years ago
moneromooo-monero	213e326cc9	abstract_tcp_server2: log init_server errors as fatal ... so they show up by default	7 years ago
moneromooo-monero	b51dc56687	use const refs in for loops for non tiny types	7 years ago
moneromooo-monero	f0568ca6ac	net_parse_helpers: fix regex error checking	7 years ago
moneromooo-monero	b49ddc766d	check accessing an element past the end of a container	7 years ago
moneromooo-monero	2305bf260d	check return value for generate_key_derivation and derive_public_key	7 years ago
moneromooo-monero	a4240d9ffc	catch const exceptions	7 years ago
moneromooo-monero	45a1c4c088	add empty container sanity checks when using front() and back()	7 years ago
moneromooo-monero	56fa6ce15f	tests: fix a buffer overread in a unit test ... and remove a leftover debugging sanity check	7 years ago
moneromooo-monero	b4524892fb	rpc: guard against json parsing a non object	7 years ago
moneromooo-monero	c2ed8618e4	easylogging++: avoid buffer underflow	7 years ago
moneromooo-monero	187a6ab2d2	epee: trap failure to parse URI from request	7 years ago
moneromooo-monero	061789b5dd	checkpoints: trap failure to load JSON checkpoints	7 years ago
moneromooo-monero	ba2fefb9a4	checkpoints: pass std::string by const ref, not const value	7 years ago
moneromooo-monero	38c8f4e0a3	mlog: terminate a string at last char, just in case	7 years ago
moneromooo-monero	d753d716a6	fix a few leaks by throwing objects, not newed pointers to objects	7 years ago
moneromooo-monero	fe568db83d	p2p: use size_t for arbitrary counters instead of uint8_t	7 years ago
moneromooo-monero	46d6fa35c9	cryptonote_protocol: sanity check chain hashes from peer	7 years ago
moneromooo-monero	25584f8639	cryptonote_protocol: print peer versions when unexpected ... also avoid integer underflow on zero height	7 years ago
moneromooo-monero	490a5d41ca	rpc: do not try to use an invalid txid in relay_tx	7 years ago
Riccardo Spagni	1cc7451130	Merge pull request #2134 ... ceabc4f9 change the N-1/N multisig second message signer for auth (moneromooo-monero) 55c2845d core_tests: multisig test now tests multiple inputs (moneromooo-monero) 98db7ee4 wallet: factor multisig info parsing (moneromooo-monero) 31a97e76 wallet: use raw encrypted data in multisig import/export RPC (moneromooo-monero) 2fa707d1 wallet: add multisig sign/submit RPC (moneromooo-monero) e36f5b60 Match surae's recommendation to derive multisig keys (moneromooo-monero) a36c261d wallet2: fix slow multisig unit tests with subaddress patch (moneromooo-monero) fa569712 make multisig work with subaddresses (moneromooo-monero) dffa0dce simplewallet: add export_raw_multisig command (moneromooo-monero) 7f4c220b simplewallet: add multisig to wallet type in wallet_info output (moneromooo-monero) 26529038 wallet: guard against partly initialized multisig wallet (moneromooo-monero) 66e34e85 add multisig core test and factor multisig building blocks (moneromooo-monero) f4eda44c N-1/N multisig (moneromooo-monero) cd64c799 multisig address generation RPC (moneromooo-monero) fff871a4 gen_multisig: generates multisig wallets if participants trust each other (moneromooo-monero) 95a21a79 wallet2: allow empty wallet filename to avoid saving data (moneromooo-monero) b84b3565 tests: add multisig unit tests (moneromooo-monero) 4c313324 Add N/N multisig tx generation and signing (moneromooo-monero) 6d219a92 wallet: add multisig key generation (moneromooo-monero)	7 years ago
Riccardo Spagni	2879a9be3c	Merge pull request #2950 ... d9b137f1 cryptonote_core: fix blockchain init call after prototype change (moneromooo-monero)	7 years ago
moneromooo-monero	d9b137f161	cryptonote_core: fix blockchain init call after prototype change	7 years ago
moneromooo-monero	ceabc4f92b	change the N-1/N multisig second message signer for auth	7 years ago
moneromooo-monero	55c2845d1a	core_tests: multisig test now tests multiple inputs	7 years ago
moneromooo-monero	98db7ee467	wallet: factor multisig info parsing	7 years ago
moneromooo-monero	31a97e761e	wallet: use raw encrypted data in multisig import/export RPC	7 years ago
moneromooo-monero	2fa707d1a5	wallet: add multisig sign/submit RPC	7 years ago
moneromooo-monero	e36f5b6021	Match surae's recommendation to derive multisig keys	7 years ago
moneromooo-monero	a36c261d7a	wallet2: fix slow multisig unit tests with subaddress patch ... While there, move the wallet2 ctor to the cpp file as it's a huge amount of init list now, and remove an unused one.	7 years ago
moneromooo-monero	fa5697127f	make multisig work with subaddresses ... Thanks to kenshi84 for help getting this work	7 years ago
moneromooo-monero	dffa0dceaf	simplewallet: add export_raw_multisig command ... It exports raw transactions, so they may be used by other tools, for instance to be relayed to the network externally.	7 years ago
moneromooo-monero	7f4c220b70	simplewallet: add multisig to wallet type in wallet_info output	7 years ago
moneromooo-monero	265290388b	wallet: guard against partly initialized multisig wallet	7 years ago
moneromooo-monero	66e34e85b1	add multisig core test and factor multisig building blocks	7 years ago
moneromooo-monero	f4eda44ce3	N-1/N multisig	7 years ago
moneromooo-monero	cd64c7990c	multisig address generation RPC	7 years ago
moneromooo-monero	fff871a455	gen_multisig: generates multisig wallets if participants trust each other	7 years ago
moneromooo-monero	95a21a793d	wallet2: allow empty wallet filename to avoid saving data ... Useful to speed tests up and avoid unnecessary leftover files	7 years ago
moneromooo-monero	b84b3565f3	tests: add multisig unit tests	7 years ago
moneromooo-monero	4c313324b1	Add N/N multisig tx generation and signing ... Scheme by luigi1111: Multisig for RingCT on Monero 2 of 2 User A (coordinator): Spendkey b,B Viewkey a,A (shared) User B: Spendkey c,C Viewkey a,A (shared) Public Address: C+B, A Both have their own watch only wallet via C+B, a A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants) A and B watch for incoming outputs B creates "half" key images for discovered output D: I2_D = (Hs(aR)+c) * Hp(D) B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D), and sending the pubkeys with I2_D. A also creates "half" key images: I1_D = (Hs(aR)+b) * Hp(D) Then I_D = I1_D + I2_D Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction). A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D to his own generated ones where they are needed (secret row L, R). At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r, which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo). B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well). B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D to his cache, allowing him to verify spent status as well. NOTE: A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively. Otherwise, trickery like the following becomes possible: A creates viewkey a,A, spendkey b,B, and sends a,A,B to B. B creates a fake key C = zG - B. B sends C back to A. The combined spendkey C+B then equals zG, allowing B to spend funds at any time! The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature). 2 of 3 User A (coordinator) Shared viewkey a,A "spendkey" j,J User B "spendkey" k,K User C "spendkey" m,M A collects K and M from B and C B collects J and M from A and C C collects J and K from A and B A computes N = nG, n = Hs(jK) A computes O = oG, o = Hs(jM) B anc C compute P = pG, p = Hs(kM) || Hs(mK) B and C can also compute N and O respectively if they wish to be able to coordinate Address: N+O+P, A The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other needed part of the signature/key images from either of the other two. Alternatively, if secure communication exists between parties: A gives j to B B gives k to C C gives m to A Address: J+K+M, A 3 of 3 Identical to 2 of 2, except the coordinator must collect the key images from both of the others. The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it or send it back to A. N-1 of N Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around (using either the secure or insecure method). For example (ignoring viewkey so letters line up): [4 of 5] User: spendkey A: a B: b C: c D: d E: e a -> B, b -> C, c -> D, d -> E, e -> A Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with the transaction so the signers know if they should use 1 or both keys. Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each. Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning: 1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image) 2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use. You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might also be straightforward enough to support with minimal changes from N-1 format. You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc. The process is somewhat cumbersome: To create a N/N multisig wallet: - each participant creates a normal wallet - each participant runs "prepare_multisig", and sends the resulting string to every other participant - each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N) As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent: - each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant - each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants Then, a transaction may be initiated: - one of the participants runs "transfer ADDRESS AMOUNT" - this partly signed transaction will be written to the "multisig_monero_tx" file - the initiator sends this file to another participant - that other participant runs "sign_multisig multisig_monero_tx" - the resulting transaction is written to the "multisig_monero_tx" file again - if the threshold was not reached, the file must be sent to another participant, until enough have signed - the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network	7 years ago
moneromooo-monero	6d219a9250	wallet: add multisig key generation ... Scheme by luigi1111	7 years ago
Riccardo Spagni	a3a8343051	Merge pull request #2857 ... 7193b89f Scrub keys from memory just before scope end. (moneromooo-monero)	7 years ago
Riccardo Spagni	066fd7aced	Merge pull request #2877 ... 43f5269f Wallets now do not depend on the daemon rpc lib (moneromooo-monero) bb89ae8b move connection_basic and network_throttle from src/p2p to epee (moneromooo-monero) 4abf25f3 cryptonote_core does not depend on p2p anymore (moneromooo-monero)	7 years ago
Riccardo Spagni	b806d9844e	Merge pull request #2864 ... 09ce03d6 move includes around to lessen overall load (moneromooo-monero)	7 years ago
moneromooo-monero	43f5269f84	Wallets now do not depend on the daemon rpc lib ... The shared RPC code is now moved off into a separate lib	7 years ago
moneromooo-monero	bb89ae8b20	move connection_basic and network_throttle from src/p2p to epee ... These even had the epee namespace. This fixes some ugly circular dependencies.	7 years ago
moneromooo-monero	4abf25f3c9	cryptonote_core does not depend on p2p anymore ... As a followon side effect, this makes a lot of inline code included only in particular cpp files (and instanciated when necessary.	7 years ago
moneromooo-monero	09ce03d612	move includes around to lessen overall load	7 years ago
moneromooo-monero	7193b89fe5	Scrub keys from memory just before scope end. ... Partially implements #74. Securely erases keys from memory after they are no longer needed. Might have a performance impact, which I haven't measured (perf measurements aren't generally reliable on laptops). Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod functions. Using overloads + SFINAE instead generalizes it so other types can be marked as scrubbed without adding more boilerplate.	7 years ago