Labels Milestones

LWMA v2, Cryptonight variant 2, and much much more wow #88

Merged

wowario merged 394 commits from monero into release-v0.3.0.0 6 years ago

Conversation 1 Commits 394 Files Changed 675

wowario commented 6 years ago (Migrated from github.com)

Owner

Rebased on top of Monero v0.12.3.0 with selective upstream commits... added LWMA v2, Cryptonight variant 2 (not finalized and subject to change), mandatory ring size 22. v9 fork height and guessed difficulty TBD, place holders added.

Rebased on top of Monero v0.12.3.0 with selective upstream commits... added LWMA v2, Cryptonight variant 2 (not finalized and subject to change), mandatory ring size 22. v9 fork height and guessed difficulty TBD, place holders added.

wowario commented 6 years ago (Migrated from github.com)

Owner

Cryptonote tweak v2.2 https://github.com/monero-project/monero/pull/4404 applied, which augments CNv2 effect against pre-built boards at a ~2-10% hit on GPU/CPU performance when compared to CNv1.

Cryptonote tweak v2.2 https://github.com/monero-project/monero/pull/4404 applied, which augments CNv2 effect against pre-built boards at a ~2-10% hit on GPU/CPU performance when compared to CNv1.

stoffu (Migrated from github.com) reviewed 6 years ago

src/cryptonote_basic/difficulty.cpp

stoffu (Migrated from github.com) commented 6 years ago

Owner

These checks should be written like nettype == cryptonote::MAINNET with nettype being passed by the blockchain class, since cryptonote::MAINNET is just an enum value (which happens to be zero, meaning that the branch body never gets executed).

These checks should be written like `nettype == cryptonote::MAINNET` with `nettype` being passed by the blockchain class, since `cryptonote::MAINNET` is just an enum value (which happens to be zero, meaning that the branch body never gets executed).

wowario (Migrated from github.com) reviewed 6 years ago

src/cryptonote_basic/difficulty.cpp

wowario (Migrated from github.com) commented 6 years ago

Owner

Thanks @stoffu. I'll updated the checks for the next release.

Thanks @stoffu. I'll updated the checks for the next release.

The pull request has been merged as 869b084d2c.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

V0.11 bug
Something isn't working duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right macOS question
Further information is requested wontfix
This will not be worked on

No Label V0.11 bug duplicate enhancement good first issue help wanted invalid macOS question wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wownero/wownero#88

Write Preview

Loading…

Cancel

Save

There is no content yet.