Labels Milestones

epee: add missing header #431

Merged

wowario merged 1 commits from sneurlax/wownero:fix/gcc11 into master 1 year ago

Conversation 0 Commits 1 Files Changed 3

sneurlax commented 1 year ago

See Monero commit e106bdc1fc3a9bb08837b05299088f3b6c4f66ba by @selsta. This commit includes in three epee source files in other to fix GCC11 builds, in my case for cross-compiling for Windows from Ubuntu using MinGW. I patch my files locally in order to achieve this, whereas this fix, tracking Monero upstream code, will allow builds to complete using GCC11 out of the box. See also https://github.com/MultiMC/Launcher/issues/3574 for the same issue in another repository for context.

Thank you @dsc_ and @nioc

See Monero commit [e106bdc1fc3a9bb08837b05299088f3b6c4f66ba](https://github.com/monero-project/monero/commit/e106bdc1fc3a9bb08837b05299088f3b6c4f66ba#diff-d2cb9c3ff4c4762cfd7e736b42f3eb354a361fe9f0ecd2f956c08f03eb5f3405) by [@selsta](https://github.com/selsta). This commit includes <limits> in three epee source files in other to fix GCC11 builds, in my case for cross-compiling for Windows from Ubuntu using MinGW. I patch my files locally in order to achieve this, whereas this fix, tracking Monero upstream code, will allow builds to complete using GCC11 out of the box. See also https://github.com/MultiMC/Launcher/issues/3574 for the same issue in another repository for context. Thank you @dsc_ and @nioc

sneurlax added 1 commit 1 year ago

39379d7022 epee: add missing header ...

See Monero commit [e106bdc1fc](e106bdc1fc (diff-d2cb9c3ff4c4762cfd7e736b42f3eb354a361fe9f0ecd2f956c08f03eb5f3405)) by [@selsta](https://github.com/selsta).  This commit includes <limits> in three epee source files in other to fix GCC11 builds, in my case for cross-compiling for Windows from Ubuntu using MinGW.  I patch my files locally in order to achieve this, whereas this fix, tracking Monero upstream code, will allow builds to complete using GCC11 out of the box.  See also https://github.com/MultiMC/Launcher/issues/3574 for the same issue in another repository for context.

wowario referenced this issue from a commit 1 year ago

Merge pull request 'epee: add missing header' (#431) from sneurlax/wownero:fix/gcc11 into master

wowario merged commit 833ac01ed9 into master 1 year ago

The pull request has been merged as 833ac01ed9.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

V0.11 bug
Something isn't working duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right macOS question
Further information is requested wontfix
This will not be worked on

No Label V0.11 bug duplicate enhancement good first issue help wanted invalid macOS question wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wownero/wownero#431

Write Preview

Loading…

Cancel

Save

There is no content yet.