wownero
/
wownero
7
13
Fork 13
Code Issues 8 Pull Requests Releases 41 Wiki Activity
Labels Milestones

simplewallet: tweaks to churn #162

Merged
wowario merged 1 commits from auto_churn into dev-v0.5 5 years ago
Conversation 2 Commits 1 Files Changed 4
wowario commented 5 years ago (Migrated from github.com)
Owner
There is no content yet.
fuwa0529 commented 5 years ago (Migrated from github.com)
Owner

Great, I'll work on a patch to suppress the warning in sweep_all when the recipient is oneself.

Don't expect it, C++ n00b here.

Great, I'll work on a patch to suppress the warning in `sweep_all` when the recipient is oneself. Don't expect it, C++ n00b here.
👍 1
fuwa0529 (Migrated from github.com) reviewed 5 years ago
src/wallet/wallet2.cpp
fuwa0529 (Migrated from github.com) commented 5 years ago
Owner

The default is false? Why it seems to me the logic or the naming of this var is inverted.

The default is false? Why it seems to me the logic or the naming of this var is inverted.
fuwa0529 commented 5 years ago (Migrated from github.com)
Owner

Enhancement PR in #163

Enhancement PR in #163
wowario (Migrated from github.com) reviewed 5 years ago
src/wallet/wallet2.cpp
wowario (Migrated from github.com) commented 5 years ago
Owner

I've reversed the logic

I've reversed the logic
fuwa0529 (Migrated from github.com) reviewed 5 years ago
src/wallet/wallet2.cpp
fuwa0529 (Migrated from github.com) commented 5 years ago
Owner

Now that the conditional is fixed, the default probably should be false.

Now that the conditional is fixed, the default probably should be false.
fuwa0529 (Migrated from github.com) reviewed 5 years ago
src/simplewallet/simplewallet.cpp
success_msg_writer(true) << tr("Transaction successfully submitted, transaction ") << txid << ENDL
<< tr("You can check its status by using the `show_transfers` command.");
} else {
m_wallet->commit_tx(ptx);
fuwa0529 (Migrated from github.com) commented 5 years ago
Owner

Here, float will mask the var in the outside scope, which is probably not wanted.

Here, float will mask the var in the outside scope, which is probably not wanted.
The pull request has been merged as 46441d7c23.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
V0.11 bug
Something isn't working duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right macOS question
Further information is requested wontfix
This will not be worked on
No Label V0.11 bug duplicate enhancement good first issue help wanted invalid macOS question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wownero/wownero#162
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'auto_churn'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes