blockchain_import: error out if preparing to handle blocks fails

Coverity 197562
5 years ago · bea1918a05
parent 5dbcceb664
commit bea1918a05
1 changed files with 5 additions and 1 deletions
--- a/src/blockchain_utilities/blockchain_import.cpp
+++ b/src/blockchain_utilities/blockchain_import.cpp
@ -194,7 +194,11 @@ int check_flush(cryptonote::core &core, std::vector<block_complete_entry> &block
  core.prevalidate_block_hashes(core.get_blockchain_storage().get_db().height(), hashes);

  std::vector<block> pblocks;
-  core.prepare_handle_incoming_blocks(blocks, pblocks);
+  if (!core.prepare_handle_incoming_blocks(blocks, pblocks))
+  {
+    MERROR("Failed to prepare to add blocks");
+    return 1;
+  }
  if (!pblocks.empty() && pblocks.size() != blocks.size())
  {
    MERROR("Unexpected parsed blocks size");