From bea1918a05a565e62ae682706cf98e32507191ea Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Sun, 7 Apr 2019 13:47:17 +0000 Subject: [PATCH] blockchain_import: error out if preparing to handle blocks fails Coverity 197562 --- src/blockchain_utilities/blockchain_import.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/blockchain_utilities/blockchain_import.cpp b/src/blockchain_utilities/blockchain_import.cpp index 8454595ac..cb9154f29 100644 --- a/src/blockchain_utilities/blockchain_import.cpp +++ b/src/blockchain_utilities/blockchain_import.cpp @@ -194,7 +194,11 @@ int check_flush(cryptonote::core &core, std::vector &block core.prevalidate_block_hashes(core.get_blockchain_storage().get_db().height(), hashes); std::vector pblocks; - core.prepare_handle_incoming_blocks(blocks, pblocks); + if (!core.prepare_handle_incoming_blocks(blocks, pblocks)) + { + MERROR("Failed to prepare to add blocks"); + return 1; + } if (!pblocks.empty() && pblocks.size() != blocks.size()) { MERROR("Unexpected parsed blocks size");