529 Commits (838b2e8a527a8f4008336a98d99e7cb9b18aaf75)

Author	SHA1	Message	Date
Riccardo Spagni	838b2e8a52	Merge pull request #2944 ... 223e3788 unit_tests: fix memwipe test comparison (moneromooo-monero)	7 years ago
moneromooo-monero	1e5491e942	Add a chacha20 variant to go with chacha8	7 years ago
Riccardo Spagni	2b00899bb2	Merge pull request #2920 ... bd5cce07 network_throttle: fix ineffective locking (moneromooo-monero) e0a61299 network_throttle: remove unused xxx static member (moneromooo-monero) 24f584d9 cryptonote_core: remove unused functions with off by one bugs (moneromooo-monero) b1634aa3 blockchain: don't leave dangling pointers in this (moneromooo-monero) 8e60b81c cryptonote_core: fix db leak on error (moneromooo-monero) 213e326c abstract_tcp_server2: log init_server errors as fatal (moneromooo-monero) b51dc566 use const refs in for loops for non tiny types (moneromooo-monero) f0568ca6 net_parse_helpers: fix regex error checking (moneromooo-monero) b49ddc76 check accessing an element past the end of a container (moneromooo-monero) 2305bf26 check return value for generate_key_derivation and derive_public_key (moneromooo-monero) a4240d9f catch const exceptions (moneromooo-monero) 45a1c4c0 add empty container sanity checks when using front() and back() (moneromooo-monero) 56fa6ce1 tests: fix a buffer overread in a unit test (moneromooo-monero) b4524892 rpc: guard against json parsing a non object (moneromooo-monero) c2ed8618 easylogging++: avoid buffer underflow (moneromooo-monero) 187a6ab2 epee: trap failure to parse URI from request (moneromooo-monero) 061789b5 checkpoints: trap failure to load JSON checkpoints (moneromooo-monero) ba2fefb9 checkpoints: pass std::string by const ref, not const value (moneromooo-monero) 38c8f4e0 mlog: terminate a string at last char, just in case (moneromooo-monero) d753d716 fix a few leaks by throwing objects, not newed pointers to objects (moneromooo-monero) fe568db8 p2p: use size_t for arbitrary counters instead of uint8_t (moneromooo-monero) 46d6fa35 cryptonote_protocol: sanity check chain hashes from peer (moneromooo-monero) 25584f86 cryptonote_protocol: print peer versions when unexpected (moneromooo-monero) 490a5d41 rpc: do not try to use an invalid txid in relay_tx (moneromooo-monero)	7 years ago
Riccardo Spagni	9d1c4408ad	Merge pull request #2905 ... bd1f6029 http_client: rewrite header parsing manually for speed (moneromooo-monero) ec724eb6 tests: add levin fuzz test (moneromooo-monero) f1bdc9a4 tests: add http client fuzz test (moneromooo-monero) 0272df9e add parse_url fuzz test (moneromooo-monero) 261b0dd0 tests: add base58 fuzz test (moneromooo-monero) fd052087 fuzz_testing: allow automatically resuming an interrupted job (moneromooo-monero) c80bb0eb tests: don't init stuff we don't need in fuzz tests - faster (moneromooo-monero) 53b83a83 tests: better load-from-binary fuzz test data file (moneromooo-monero) 1a379ef6 fuzz_testing: build with ASAN (assumed to be available) (moneromooo-monero) 4cd4a431 fuzz_testing: create out directory if needed, and fix filename passing (moneromooo-monero) c27d9092 Makefile: build fuzz tests statically, starts faster (moneromooo-monero) 95aa0bf7 add load_from_binary/load_from_json fuzzers (moneromooo-monero)	7 years ago
Riccardo Spagni	2f09828ea8	Merge pull request #2890 ... 83b0f9e6 version: add -master to master version (moneromooo-monero) 493f7d09 util: allow non numeric version parts (moneromooo-monero)	7 years ago
moneromooo-monero	ec724eb64a	tests: add levin fuzz test	7 years ago
moneromooo-monero	f1bdc9a42a	tests: add http client fuzz test	7 years ago
moneromooo-monero	0272df9e61	add parse_url fuzz test	7 years ago
moneromooo-monero	261b0dd0e0	tests: add base58 fuzz test	7 years ago
moneromooo-monero	c80bb0eb6f	tests: don't init stuff we don't need in fuzz tests - faster	7 years ago
moneromooo-monero	53b83a83fc	tests: better load-from-binary fuzz test data file ... Looks like there's some kind of header/signature	7 years ago
moneromooo-monero	95aa0bf79b	add load_from_binary/load_from_json fuzzers	7 years ago
moneromooo-monero	56fa6ce15f	tests: fix a buffer overread in a unit test ... and remove a leftover debugging sanity check	7 years ago
moneromooo-monero	55c2845d1a	core_tests: multisig test now tests multiple inputs	7 years ago
moneromooo-monero	e36f5b6021	Match surae's recommendation to derive multisig keys	7 years ago
moneromooo-monero	a36c261d7a	wallet2: fix slow multisig unit tests with subaddress patch ... While there, move the wallet2 ctor to the cpp file as it's a huge amount of init list now, and remove an unused one.	7 years ago
moneromooo-monero	fa5697127f	make multisig work with subaddresses ... Thanks to kenshi84 for help getting this work	7 years ago
moneromooo-monero	265290388b	wallet: guard against partly initialized multisig wallet	7 years ago
moneromooo-monero	66e34e85b1	add multisig core test and factor multisig building blocks	7 years ago
moneromooo-monero	f4eda44ce3	N-1/N multisig	7 years ago
moneromooo-monero	fff871a455	gen_multisig: generates multisig wallets if participants trust each other	7 years ago
moneromooo-monero	95a21a793d	wallet2: allow empty wallet filename to avoid saving data ... Useful to speed tests up and avoid unnecessary leftover files	7 years ago
moneromooo-monero	b84b3565f3	tests: add multisig unit tests	7 years ago
moneromooo-monero	4c313324b1	Add N/N multisig tx generation and signing ... Scheme by luigi1111: Multisig for RingCT on Monero 2 of 2 User A (coordinator): Spendkey b,B Viewkey a,A (shared) User B: Spendkey c,C Viewkey a,A (shared) Public Address: C+B, A Both have their own watch only wallet via C+B, a A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants) A and B watch for incoming outputs B creates "half" key images for discovered output D: I2_D = (Hs(aR)+c) * Hp(D) B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D), and sending the pubkeys with I2_D. A also creates "half" key images: I1_D = (Hs(aR)+b) * Hp(D) Then I_D = I1_D + I2_D Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction). A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D to his own generated ones where they are needed (secret row L, R). At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r, which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo). B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well). B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D to his cache, allowing him to verify spent status as well. NOTE: A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively. Otherwise, trickery like the following becomes possible: A creates viewkey a,A, spendkey b,B, and sends a,A,B to B. B creates a fake key C = zG - B. B sends C back to A. The combined spendkey C+B then equals zG, allowing B to spend funds at any time! The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature). 2 of 3 User A (coordinator) Shared viewkey a,A "spendkey" j,J User B "spendkey" k,K User C "spendkey" m,M A collects K and M from B and C B collects J and M from A and C C collects J and K from A and B A computes N = nG, n = Hs(jK) A computes O = oG, o = Hs(jM) B anc C compute P = pG, p = Hs(kM) || Hs(mK) B and C can also compute N and O respectively if they wish to be able to coordinate Address: N+O+P, A The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other needed part of the signature/key images from either of the other two. Alternatively, if secure communication exists between parties: A gives j to B B gives k to C C gives m to A Address: J+K+M, A 3 of 3 Identical to 2 of 2, except the coordinator must collect the key images from both of the others. The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it or send it back to A. N-1 of N Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around (using either the secure or insecure method). For example (ignoring viewkey so letters line up): [4 of 5] User: spendkey A: a B: b C: c D: d E: e a -> B, b -> C, c -> D, d -> E, e -> A Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with the transaction so the signers know if they should use 1 or both keys. Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each. Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning: 1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image) 2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use. You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might also be straightforward enough to support with minimal changes from N-1 format. You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc. The process is somewhat cumbersome: To create a N/N multisig wallet: - each participant creates a normal wallet - each participant runs "prepare_multisig", and sends the resulting string to every other participant - each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N) As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent: - each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant - each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants Then, a transaction may be initiated: - one of the participants runs "transfer ADDRESS AMOUNT" - this partly signed transaction will be written to the "multisig_monero_tx" file - the initiator sends this file to another participant - that other participant runs "sign_multisig multisig_monero_tx" - the resulting transaction is written to the "multisig_monero_tx" file again - if the threshold was not reached, the file must be sent to another participant, until enough have signed - the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network	7 years ago
Riccardo Spagni	a3a8343051	Merge pull request #2857 ... 7193b89f Scrub keys from memory just before scope end. (moneromooo-monero)	7 years ago
Riccardo Spagni	066fd7aced	Merge pull request #2877 ... 43f5269f Wallets now do not depend on the daemon rpc lib (moneromooo-monero) bb89ae8b move connection_basic and network_throttle from src/p2p to epee (moneromooo-monero) 4abf25f3 cryptonote_core does not depend on p2p anymore (moneromooo-monero)	7 years ago
moneromooo-monero	223e3788ac	unit_tests: fix memwipe test comparison ... free might overwrite the memory, so we can't expect to see the NULs we overwrote with, but at least we shouldn't see the original data.	7 years ago
moneromooo-monero	4abf25f3c9	cryptonote_core does not depend on p2p anymore ... As a followon side effect, this makes a lot of inline code included only in particular cpp files (and instanciated when necessary.	7 years ago
moneromooo-monero	09ce03d612	move includes around to lessen overall load	7 years ago
moneromooo-monero	7193b89fe5	Scrub keys from memory just before scope end. ... Partially implements #74. Securely erases keys from memory after they are no longer needed. Might have a performance impact, which I haven't measured (perf measurements aren't generally reliable on laptops). Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod functions. Using overloads + SFINAE instead generalizes it so other types can be marked as scrubbed without adding more boilerplate.	7 years ago
Riccardo Spagni	6c0953b15a	Merge pull request #2860 ... 3dffe71b new wipeable_string class to replace std::string passphrases (moneromooo-monero) 7a2a5741 utils: initialize easylogging++ in on_startup (moneromooo-monero) 54950829 use memwipe in a few relevant places (moneromooo-monero) 000666ff add a memwipe function (moneromooo-monero)	7 years ago
moneromooo-monero	c83d0b3ee2	add bulletproofs from v7 on testnet	7 years ago
moneromooo-monero	d58835b2f6	integrate bulletproofs into monero	7 years ago
moneromooo-monero	90b8d9f271	add bulletproofs to the build, with basic unit tests ... Based on Java code from Sarang Noether	7 years ago
moneromooo-monero	493f7d0974	util: allow non numeric version parts	7 years ago
moneromooo-monero	3dffe71b72	new wipeable_string class to replace std::string passphrases	7 years ago
moneromooo-monero	000666ff78	add a memwipe function ... It's meant to avoid being optimized out memory_cleanse lifted from bitcoin	7 years ago
moneromooo-monero	37c1ce3b68	tests: disable libwallet_api_tests when BUILD_GUI_DEPS is not set	7 years ago
Riccardo Spagni	2e54e7ff0b	Merge pull request #2824 ... 51895fd7 split wallet and wallet_api (moneromooo-monero)	7 years ago
moneromooo-monero	51895fd7df	split wallet and wallet_api ... This speeds up building a lot when wallet2.h (or something it includes) changes, since all the API includes wallet2.h	7 years ago
moneromooo-monero	f493eabba7	unit_tests: fix running without --data-dir ... While there, also use the new is_arg_defaulted API instead of going to poke the internal API directly.	7 years ago
Riccardo Spagni	5c2dfe157b	Merge pull request #2771 ... e3e838d0 kaccak: remove unused return value (moneromooo-monero) 4877aca2 keccak: some paranoid "can't happen" checks (moneromooo-monero)	7 years ago
Riccardo Spagni	74b699beda	Merge pull request #2812 ... 9ac52127 unit_tests: fix build after wallet2 list/vector change (moneromooo-monero)	7 years ago
Riccardo Spagni	edebe4e3b6	Merge pull request #2736 ... 0d9c0db9 Do not build against epee_readline if it was not built (Howard Chu) 178014c9 split off readline code into epee_readline (moneromooo-monero) a9e14a19 link against readline only for monerod and wallet-wallet-{rpc,cli} (moneromooo-monero) 437421ce wallet: move some scoped_message_writer calls from the libs (moneromooo-monero) e89994e9 wallet: rejig to avoid prompting in wallet2 (moneromooo-monero) ec5135e5 move input_line from command_line to simplewallet (moneromooo-monero) 082db75f move cryptonote command line options to cryptonote_core (moneromooo-monero)	7 years ago
Riccardo Spagni	922aaf4e2a	Merge pull request #2644 ... a17efcb0 make this build on SunOS/Solaris (Pavel Maryanov)	7 years ago
moneromooo-monero	9ac5212775	unit_tests: fix build after wallet2 list/vector change	7 years ago
moneromooo-monero	082db75f28	move cryptonote command line options to cryptonote_core ... Those have no reason to be in a generic module	7 years ago
Pavel Maryanov	a17efcb039	make this build on SunOS/Solaris	7 years ago
moneromooo-monero	383ff4f689	remove "using namespace std" from headers ... It's nasty, and actually breaks on Solaris, where if.h fails to build due to: struct map *if_memmap;	7 years ago
Riccardo Spagni	4754390725	Merge pull request #2720 ... 110339f5 unit_tests: fix data dir determination (moneromooo-monero)	7 years ago