2192 Commits (ce6b83128e343687d526479f1a308d838a38f02a)

 

All Branches   

Search

Author	SHA1	Message	Date
redfish	ce6b83128e	daemonizer: posix: keep parent's working dir and umask ... Keep the working directory (and umask) inherited from the parent. Otherwise, it's impossible to control the working directory of the daemon (from systemd, for example). Furthermoer, bitmonerod attempts to create logging directories and files *in current working directory*. This fails due to permission denied and generates a (caught, nonfatal) exception. Below is the strace with this patch applied (so, no `chdir("/")`), showing successful opens at `log/` relative path. Without this patch they fail (sorry, didn't save the trace). ``` 28911 getcwd("/.../bitmonero", 128) = 25 28911 stat64("/var/lib/bitmonero/.bitmonero", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0 28911 stat64("/etc/bitmonerod.conf", {st_mode=S_IFREG|0644, st_size=244, ...}) = 0 28911 open("/etc/bitmonerod.conf", O_RDONLY|O_LARGEFILE) = 3 28911 open("/var/log/bitmonero/bitmonero.log", O_WRONLY|O_CREAT|O_APPEND|O_LARGEFILE, 0666) = 3 28911 stat64("log", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 28911 stat64("log/dbg", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 28911 open("log/dbg/main.log", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = 4 ``` The reasoning of chdir("/") in order to prevent the daemon from holding a filesystem in busy state is not compelling at all: the choice of working directory for the daemon is the user's business not the daemon's.	8 years ago
Riccardo Spagni	18dd507024	Merge pull request #889 ... a0bf85d wallet2_api: make this build (smatch needs .str() for /=) (moneromooo-monero)	8 years ago
moneromooo-monero	a0bf85d09d	wallet2_api: make this build (smatch needs .str() for /=)	8 years ago
Riccardo Spagni	59172156bf	Merge pull request #885 ... b727a1f updated README to reflect Windows changes (Riccardo Spagni)	8 years ago
Riccardo Spagni	18fa01c092	Merge pull request #884 ... c2ad9ca allow peers without port (moneromooo-monero)	8 years ago
Riccardo Spagni	1088ed862b	Merge pull request #883 ... 459ec60 daemon: print exception errors when failing to parse config file (moneromooo-monero)	8 years ago
Riccardo Spagni	0b65717a5d	Merge pull request #882 ... f11191a rpc: restrict number of fake outs requested in restricted rpc mode (moneromooo-monero)	8 years ago
Riccardo Spagni	00fd89a36d	Merge pull request #879 ... 6b08001 simplewallet: mention the background refresh thread when starting (moneromooo-monero)	8 years ago
Riccardo Spagni	3923cbddaf	Merge pull request #878 ... 945c272 wallet: add a fee multiplier (moneromooo-monero)	8 years ago
Riccardo Spagni	65df33fb06	Merge pull request #877 ... ecd0f2d makefile: remove unnecessary ARM-specific targets (redfish) c650160 cmake: disable AES on ARM (redfish) 804b1bc cmake: initialize ARCH for native builds (redfish) bb39034 cmake: remove repetitive code in handling of NO_AES (redfish)	8 years ago
Riccardo Spagni	c9f66dfaba	Merge pull request #876 ... 72287d1 contrib: epee: add missing noexcept spec to class decl (redfish)	8 years ago
Riccardo Spagni	160e808796	Merge pull request #875 ... 14f7538 readme: move license to separate file for packaging (redfish)	8 years ago
Riccardo Spagni	628f57b212	Merge pull request #873 ... d718960 remove POSIX_C_SOURCE and remove dlfcn.h for static builds (luigi1111)	8 years ago
Riccardo Spagni	fc58069731	Merge pull request #872 ... beb6d92 CMake: GPL 'libutils' script removed (Ilya Kitaev) 4e5521d PendingTransactionImpl: pointer->reference (Ilya Kitaev) 7b7cf21 commented regex (Ilya Kitaev) eec0f57 Typo fixed (Ilya Kitaev) f1c4a37 Wallet::createTransaction: added mixin_count param (Ilya Kitaev) 3318add double/string to monero integer convertion methods (Ilya Kitaev) 3ac20a4 wallet::default_mixin exposed to public interface as Wallet::setDefaultMixin, Wallet::defaultMixin; wallet::create_transaction_2 used in Wallet::createTransaction (Ilya Kitaev) c554055 Wallet::filename, Wallet::keysFilename, tests for move wallet (Ilya Kitaev) 8f9d98b removed unused "using" (Ilya Kitaev) 2facbe7 Wallet API : WalletManager::findWallets() added (Ilya Kitaev) ec949c3 scripts for faster test wallets generation (Ilya Kitaev) 7f3d28f regenerated test wallets, basic functions got broken (Ilya Kitaev) 4327548 installing wallet_api header (Ilya Kitaev) 7ac1342 cmake: BUILD_TESTS as option explicitly; added missed dependency (Ilya Kitaev) 1f0d016 cmake libutils dependency added (Ilya Kitaev) d43ad22 all wallet dependencies merged to single static lib (Ilya Kitaev) 9ae4e87 WalletListener::moneyReceived test (Ilya Kitaev) 40087a7 WalletListener::moneySpent test (Ilya Kitaev) 27d86b7 WalletListener::moneySpent(), WalletListener::moneyReceived() (Ilya Kitaev) ff52c67 i_wallet_callback: virtual dtor (Ilya Kitaev) 5dbd2b8 started WalletListener (Ilya Kitaev) 71131a8 TransactionHistory continued (Ilya Kitaev) 9311934 TransactionHistory continued (Ilya Kitaev) 566166a merged with upstream (Ilya Kitaev) 53a97bd Wallet API: transaction history in progress (Ilya Kitaev) 02c9df5 Wallet API : transaction history in progress (Ilya Kitaev) a213887 transaction history api in progress (Ilya Kitaev) b6aaf53 transaction history api in progress (Ilya Kitaev) f83f3cb api implementation splitted over separate files (Ilya Kitaev) 4e1c2dc TransactionInfo / TransactionHistory APIs design (Ilya Kitaev) 1774d95 TODOs for Transaction/Transfer interface (Ilya Kitaev) d97e9ef Transaction API continued (Ilya Kitaev) 079fbd3 Wallet::createTransaction API introduced (Ilya Kitaev) ee5bb17 Wallet::transfer() continued (Ilya Kitaev) c37c856 Wallet::transfer in progress (Ilya Kitaev) 830c19c Wallet::refresh + tests (Ilya Kitaev) 1ae9cdc "testnet" is default parameter (Ilya Kitaev) 2157a9a testnet option, Wallet::balance(), Wallet::unlockedBalance() (Ilya Kitaev) 8790904 - testnet option added to api; (Ilya Kitaev) 2cce329 wallet2::store() implemented within wallet2::store_to (Ilya Kitaev) d608647 WalletManager::findWallets: searching by "keys" files instead of "address.txt" files (Ilya Kitaev) ca61153 Wallet: payment id and integrated address (Ilya Kitaev) 23cbf6f PendingTransactionImpl: pointer->reference (Ilya Kitaev) c1d9e7c commented regex (Ilya Kitaev) 563baf1 Typo fixed (Ilya Kitaev) 2efec04 Wallet::createTransaction: added mixin_count param (Ilya Kitaev) 85a6322 double/string to monero integer convertion methods (Ilya Kitaev) e7d8f2a wallet::default_mixin exposed to public interface as Wallet::setDefaultMixin, Wallet::defaultMixin; wallet::create_transaction_2 used in Wallet::createTransaction (Ilya Kitaev) a537489 Wallet::filename, Wallet::keysFilename, tests for move wallet (Ilya Kitaev) a1eddcd removed unused "using" (Ilya Kitaev) 8390bfa Wallet API : WalletManager::findWallets() added (Ilya Kitaev) 44cc0ef scripts for faster test wallets generation (Ilya Kitaev) 2060bfe regenerated test wallets, basic functions got broken (Ilya Kitaev) dbc0b03 installing wallet_api header (Ilya Kitaev) 653c7e3 cmake: BUILD_TESTS as option explicitly; added missed dependency (Ilya Kitaev) ef9a74c cmake libutils dependency added (Ilya Kitaev) 191cb59 all wallet dependencies merged to single static lib (Ilya Kitaev) 91eeeb8 WalletListener::moneyReceived test (Ilya Kitaev) 64348a2 WalletListener::moneySpent test (Ilya Kitaev) 060bb62 WalletListener::moneySpent(), WalletListener::moneyReceived() (Ilya Kitaev) 214014c i_wallet_callback: virtual dtor (Ilya Kitaev) 3745770 started WalletListener (Ilya Kitaev) e6fdd5d TransactionHistory continued (Ilya Kitaev) 3dd4b4c merged with upstream (Ilya Kitaev) d500272 Wallet API : transaction history in progress (Ilya Kitaev) 663ed04 transaction history api in progress (Ilya Kitaev) 12345d3 api implementation splitted over separate files (Ilya Kitaev) 60508e6 TransactionInfo / TransactionHistory APIs design (Ilya Kitaev) 951f3b5 Wallet::createTransaction API introduced (Ilya Kitaev) 7c51227 Wallet::transfer in progress (Ilya Kitaev) e04c67a Wallet::refresh + tests (Ilya Kitaev) 9cdf0b7 "testnet" is default parameter (Ilya Kitaev) caf0e02 testnet option, Wallet::balance(), Wallet::unlockedBalance() (Ilya Kitaev) 8df820b - testnet option added to api; (Ilya Kitaev) 94eaeb5 wallet2::store() implemented within wallet2::store_to (Ilya Kitaev)	8 years ago
Riccardo Spagni	b727a1ffbf	updated README to reflect Windows changes	8 years ago
moneromooo-monero	c2ad9caf01	allow peers without port ... The default port is then used	8 years ago
moneromooo-monero	459ec6040e	daemon: print exception errors when failing to parse config file ... When an exception happens while reading the config file, we need to print the error, as the logging system isn't initialized yet, so the generic catch will not print anything.	8 years ago
moneromooo-monero	f11191a818	rpc: restrict number of fake outs requested in restricted rpc mode	8 years ago
Ilya Kitaev	beb6d9200d	CMake: GPL 'libutils' script removed	8 years ago
redfish	ecd0f2dde7	makefile: remove unnecessary ARM-specific targets ... * NO_AES is determined automatically * BUILD_64 is determined automatically	8 years ago
Ilya Kitaev	ab61ba0c9b	Merge branch 'master' of https://github.com/mbg033/bitmonero	8 years ago
Ilya Kitaev	d60864785f	WalletManager::findWallets: searching by "keys" files instead of ... "address.txt" files	8 years ago
Ilya Kitaev	ca61153003	Wallet: payment id and integrated address	8 years ago
Ilya Kitaev	23cbf6fd97	PendingTransactionImpl: pointer->reference	8 years ago
Ilya Kitaev	c1d9e7cd2a	commented regex	8 years ago
Ilya Kitaev	563baf1b68	Typo fixed	8 years ago
Ilya Kitaev	2efec04f74	Wallet::createTransaction: added mixin_count param	8 years ago
Ilya Kitaev	85a632244e	double/string to monero integer convertion methods	8 years ago
Ilya Kitaev	e7d8f2a085	wallet::default_mixin exposed to public interface as ... Wallet::setDefaultMixin, Wallet::defaultMixin; wallet::create_transaction_2 used in Wallet::createTransaction	8 years ago
Ilya Kitaev	a5374897f8	Wallet::filename, Wallet::keysFilename, tests for move wallet	8 years ago
Ilya Kitaev	a1eddcd693	removed unused "using"	8 years ago
Ilya Kitaev	8390bfa770	Wallet API : WalletManager::findWallets() added	8 years ago
Ilya Kitaev	44cc0ef147	scripts for faster test wallets generation	8 years ago
Ilya Kitaev	2060bfe5ad	regenerated test wallets, basic functions got broken	8 years ago
Ilya Kitaev	dbc0b039b4	installing wallet_api header	8 years ago
Ilya Kitaev	653c7e3804	cmake: BUILD_TESTS as option explicitly; added missed dependency	8 years ago
Ilya Kitaev	ef9a74c67e	cmake libutils dependency added	8 years ago
Ilya Kitaev	191cb594de	all wallet dependencies merged to single static lib	8 years ago
Ilya Kitaev	91eeeb8989	WalletListener::moneyReceived test	8 years ago
Ilya Kitaev	64348a2d11	WalletListener::moneySpent test	8 years ago
Ilya Kitaev	060bb62e29	WalletListener::moneySpent(), WalletListener::moneyReceived()	8 years ago
Ilya Kitaev	214014c048	i_wallet_callback: virtual dtor	8 years ago
Ilya Kitaev	374577018d	started WalletListener	8 years ago
Ilya Kitaev	e6fdd5dd10	TransactionHistory continued	8 years ago
Ilya Kitaev	3dd4b4ccf9	merged with upstream	8 years ago
Ilya Kitaev	d500272fa8	Wallet API : transaction history in progress	8 years ago
Ilya Kitaev	663ed04eb8	transaction history api in progress	8 years ago
Ilya Kitaev	12345d382c	api implementation splitted over separate files	8 years ago
Ilya Kitaev	60508e6bae	TransactionInfo / TransactionHistory APIs design	8 years ago
Ilya Kitaev	951f3b5d83	Wallet::createTransaction API introduced ... Transaction API continued TODOs for Transaction/Transfer interface	8 years ago