Add tests

.travis.yml

@@ -0,0 +1,6 @@
+---
+language: node_js
+node_js:
+  - "8"
+  - "9"
+script: "npm run test"

app.js

@@ -0,0 +1,49 @@
+/*
+ * Copyright 2018 Excitable Aardvark <excitableaardvark@tutanota.de>
+ *
+ * Licensed under the 3-Clause BSD license. See LICENSE in the project root for
+ * more information.
+ */
+
+const Daemon = require('monero-rpc').Daemon
+const express = require('express')
+const prometheus = require('prom-client')
+const util = require('util')
+
+const DAEMON_HOST = process.env.DAEMON_HOST || 'http://localhost:18081'
+const Gauge = prometheus.Gauge
+
+const app = express()
+const daemon = new Daemon(DAEMON_HOST)
+
+let getInfo = util.promisify(daemon.getInfo.bind(daemon))
+let getLastBlockHeader = util.promisify(daemon.getLastBlockHeader.bind(daemon))
+
+const difficulty = new Gauge({ name: 'monerod_block_difficulty', help: 'Last block difficulty' })
+const incomingConnections = new Gauge({ name: 'monerod_connections_incoming', help: 'Number of incoming connections' })
+const mempoolSize = new Gauge({ name: 'monerod_tx_mempool', help: 'Number of transactions in the mempool' })
+const outgoingConnections = new Gauge({ name: 'monerod_connections_outgoing', help: 'Number of outgoing connections' })
+const reward = new Gauge({ name: 'monerod_block_reward', help: 'Last block reward' })
+const txCount = new Gauge({ name: 'monerod_tx_chain', help: 'Number of transactions in total' })
+
+app.get('/metrics', (req, res) => {
+  Promise.all([
+    getInfo(),
+    getLastBlockHeader()
+  ])
+    .then(([info, header]) => {
+      difficulty.set(Number(header.difficulty))
+      incomingConnections.set(Number(info.incoming_connections_count))
+      mempoolSize.set(Number(info.tx_pool_size))
+      outgoingConnections.set(Number(info.outgoing_connections_count))
+      reward.set(Number(header.reward / 1e12))
+      txCount.set(Number(info.tx_count))
+
+      res.end(prometheus.register.metrics())
+    })
+    .catch(e => {
+      console.log(e)
+    })
+})
+
+module.exports = app

app.test.js

@@ -0,0 +1,114 @@
+/*
+ * Copyright 2018 Excitable Aardvark <excitableaardvark@tutanota.de>
+ *
+ * Licensed under the 3-Clause BSD license. See LICENSE in the project root for
+ * more information.
+ */
+
+/* eslint-env jest */
+
+const rewire = require('rewire')
+const request = require('supertest')
+
+const app = rewire('./app.js')
+
+beforeEach(() => {
+  // mock getInfo
+  app.__set__('getInfo', () => {
+    return new Promise(resolve => {
+      resolve({
+        'alt_blocks_count': 5,
+        'difficulty': 972165250,
+        'grey_peerlist_size': 2280,
+        'height': 993145,
+        'incoming_connections_count': 20,
+        'outgoing_connections_count': 8,
+        'status': 'OK',
+        'target': 60,
+        'target_height': 993137,
+        'testnet': false,
+        'top_block_hash': '',
+        'tx_count': 564287,
+        'tx_pool_size': 45,
+        'white_peerlist_size': 529
+      })
+    })
+  })
+
+  // mock getLastBlockHeader
+  app.__set__('getLastBlockHeader', () => {
+    return new Promise(resolve => {
+      resolve({
+        'depth': 0,
+        'difficulty': 746963928,
+        'hash': 'ac0f1e2262...',
+        'height': 990793,
+        'major_version': 1,
+        'minor_version': 1,
+        'nonce': 1550,
+        'orphan_status': false,
+        'prev_hash': '386575e3b0...',
+        'reward': 6856609225169,
+        'timestamp': 1457589942
+      })
+    })
+  })
+})
+
+describe('metrics endpoint', () => {
+  test('it has a status code of 200', () => {
+    return request(app)
+      .get('/metrics')
+      .then(response => {
+        expect(response.statusCode).toBe(200)
+      })
+  })
+
+  test('it contains the difficulty', () => {
+    return request(app)
+      .get('/metrics')
+      .then(response => {
+        expect(response.text).toContain('monerod_block_difficulty 746963928')
+      })
+  })
+
+  test('it contains the number of incoming connections', () => {
+    return request(app)
+      .get('/metrics')
+      .then(response => {
+        expect(response.text).toContain('monerod_connections_incoming 20')
+      })
+  })
+
+  test('it contains the number of transactions in the mempool', () => {
+    return request(app)
+      .get('/metrics')
+      .then(response => {
+        expect(response.text).toContain('monerod_tx_mempool 45')
+      })
+  })
+
+  test('it contains the number of outgoing connections', () => {
+    return request(app)
+      .get('/metrics')
+      .then(response => {
+        expect(response.text).toContain('monerod_connections_outgoing 8')
+      })
+  })
+
+  test('it contains the last block reward', () => {
+    return request(app)
+      .get('/metrics')
+      .then(response => {
+        expect(response.text).toContain('monerod_block_reward 6.856609225169')
+      })
+  })
+
+  test('it contains the number of transactions on the chain', () => {
+    return request(app)
+      .get('/metrics')
+      .then(response => {
+        expect(response.text).toContain('monerod_tx_chain 564287')
+      })
+  })
+})

index.js

@@ -1,50 +1,5 @@
-/*
- * Copyright 2018 Excitable Aardvark <excitableaardvark@tutanota.de>
- *
- * Licensed under the 3-Clause BSD license. See LICENSE in the project root for
- * more information.
- */
+const app = require('./app')
 
-const Daemon = require('monero-rpc').Daemon
-const express = require('express')
-const prometheus = require('prom-client')
-const util = require('util')
-
-const DAEMON_HOST = process.env.DAEMON_HOST || 'http://localhost:18081'
 const PORT = process.env.PORT || 9396
-const Gauge = prometheus.Gauge
-
-const app = express()
-const daemon = new Daemon(DAEMON_HOST)
-
-const getInfo = util.promisify(daemon.getInfo.bind(daemon))
-const getLastBlockHeader = util.promisify(daemon.getLastBlockHeader.bind(daemon))
-
-const difficulty = new Gauge({ name: 'monerod_block_difficulty', help: 'Last block difficulty' })
-const incomingConnections = new Gauge({ name: 'monerod_connections_incoming', help: 'Number of incoming connections' })
-const mempoolSize = new Gauge({ name: 'monerod_tx_mempool', help: 'Number of transactions in the mempool' })
-const outgoingConnections = new Gauge({ name: 'monerod_connections_outgoing', help: 'Number of outgoing connections' })
-const reward = new Gauge({ name: 'monerod_block_reward', help: 'Last block reward' })
-const txCount = new Gauge({ name: 'monerod_tx_chain', help: 'Number of transactions in total' })
-
-app.get('/metrics', (req, res) => {
-  Promise.all([
-    getInfo(),
-    getLastBlockHeader()
-  ])
-    .then(([info, header]) => {
-      difficulty.set(Number(header.difficulty))
-      incomingConnections.set(Number(info.incoming_connections_count))
-      mempoolSize.set(Number(info.tx_pool_size))
-      outgoingConnections.set(Number(info.outgoing_connections_count))
-      reward.set(Number(header.reward / 1e12))
-      txCount.set(Number(info.tx_count))
-
-      res.end(prometheus.register.metrics())
-    })
-    .catch(e => {
-      console.log(e)
-    })
-})
 
 app.listen(PORT, () => console.log(`Listening on :${PORT}`))

package.json

@@ -5,7 +5,7 @@
   "main": "index.js",
   "scripts": {
     "lint": "eslint .",
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "eslint . && jest"
   },
   "keywords": [
     "monero",
@@ -32,6 +32,9 @@
     "eslint-plugin-import": "^2.8.0",
     "eslint-plugin-node": "^6.0.0",
     "eslint-plugin-promise": "^3.6.0",
-    "eslint-plugin-standard": "^3.0.1"
+    "eslint-plugin-standard": "^3.0.1",
+    "jest": "^22.2.1",
+    "rewire": "^3.0.2",
+    "supertest": "^3.0.0"
   }
 }