asymptotically
/
wownero
forked from wownero/wownero
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

use block id

Browse Source
master
wowario 4 years ago
parent 5b46a0df6d
commit 8757282908
No known key found for this signature in database
GPG Key ID: 24DCBE762DE9C111
4 changed files with 25 additions and 26 deletions
Show Stats Download Patch File Download Diff File

28
src/cryptonote_core/blockchain.cpp
Unescape View File

@ -1386,25 +1386,25 @@ bool Blockchain::prevalidate_miner_transaction(const block& b, uint64_t height,
MDEBUG("Miner tx hash: " << get_transaction_hash(b.miner_tx)); MDEBUG("Miner tx hash: " << get_transaction_hash(b.miner_tx));
// Dynamic unlock time from HF 16 // Dynamic unlock time from HF 16
// To calculate unlock window, use first 3 characters of tx public key (convert hex to decimal), // To calculate unlock window, get the block hash at height-1337, convert the
// multiply by 2, plus last 3 numbers of already_generated_coins, plus last numbers of block height, plus 288 // first 3 characters from hexadecimal to decimal, multiply by 2, and then add 288.
// Unlock minimum 1 day (288 blocks), maximum is ~33 days ((4095*2)+999+99+288 = 9576 blocks) // Unlock minimum 1 day (288 blocks), maximum is ~29 days ((4095*2)+288 = 8478 blocks)
// unlock time = unlock_window + height // unlock time = unlock_window + height
if (hf_version >= HF_VERSION_DYNAMIC_UNLOCK) if (hf_version >= HF_VERSION_DYNAMIC_UNLOCK)
{ {
crypto::public_key tx_pub_key = cryptonote::get_tx_pub_key_from_extra(b.miner_tx); crypto::hash blk_id = get_block_id_by_height(height-1337);
std::string hex_str = epee::string_tools::pod_to_hex(tx_pub_key).substr(0, 3); std::string hex_str = epee::string_tools::pod_to_hex(blk_id).substr(0, 3);
uint64_t pub_key_num = std::stol(hex_str,nullptr,16) * 2; uint64_t blk_num = std::stol(hex_str,nullptr,16)*2;
uint64_t coin_gen_num = m_db->get_block_already_generated_coins(height - 1) % 1000; uint64_t unlock_window = blk_num + 288;
uint64_t h_num = height % 100;
uint64_t unlock_window = pub_key_num + coin_gen_num + h_num + 288;
if (b.miner_tx.unlock_time != height + unlock_window) { if (b.miner_tx.unlock_time != height + unlock_window) {
MWARNING("Coinbase transaction has the wrong unlock time=" << b.miner_tx.unlock_time << ", expected " << height + unlock_window); MWARNING("Coinbase transaction has the wrong unlock time=" << b.miner_tx.unlock_time << ", expected " << height + unlock_window);
return false; return false;
} }
LOG_PRINT_L1("+++++ MINER TX UNLOCK TIME INFO\n" << "Height: " << height << ", Unlock window: " << unlock_window << ", Unlock time: " << b.miner_tx.unlock_time << LOG_PRINT_L1("+++++ MINER TX UNLOCK TIME INFO" <<
"\nMiner TX:\t" << get_transaction_hash(b.miner_tx) << "\nTX Pub Key:\t" << tx_pub_key << "\nHeight: " << height << ", Unlock window: " << unlock_window << ", Unlock time: " << b.miner_tx.unlock_time <<
"\nPub Key Num: " << pub_key_num << ", Coin Gen Num: " << coin_gen_num << ", Height Num: " << h_num); "\nblk_height: " << height-1337 << ", blk_id: " << blk_id <<
"\nhex_str: " << hex_str << ", blk_num: " << blk_num);
} else { } else {
CHECK_AND_ASSERT_MES(b.miner_tx.unlock_time == height + 60, false, "coinbase transaction transaction has the wrong unlock time=" CHECK_AND_ASSERT_MES(b.miner_tx.unlock_time == height + 60, false, "coinbase transaction transaction has the wrong unlock time="
<< b.miner_tx.unlock_time << ", expected " << height + 60); << b.miner_tx.unlock_time << ", expected " << height + 60);
@ -1746,7 +1746,7 @@ bool Blockchain::create_block_template(block& b, const crypto::hash *from_block,
//make blocks coin-base tx looks close to real coinbase tx to get truthful blob weight //make blocks coin-base tx looks close to real coinbase tx to get truthful blob weight
uint8_t hf_version = b.major_version; uint8_t hf_version = b.major_version;
size_t max_outs = hf_version >= 4 ? 1 : 11; size_t max_outs = hf_version >= 4 ? 1 : 11;
bool r = construct_miner_tx(height, median_weight, already_generated_coins, txs_weight, fee, miner_address, b.miner_tx, ex_nonce, max_outs, hf_version); bool r = construct_miner_tx(this, height, median_weight, already_generated_coins, txs_weight, fee, miner_address, b.miner_tx, ex_nonce, max_outs, hf_version);
CHECK_AND_ASSERT_MES(r, false, "Failed to construct miner tx, first chance"); CHECK_AND_ASSERT_MES(r, false, "Failed to construct miner tx, first chance");
size_t cumulative_weight = txs_weight + get_transaction_weight(b.miner_tx); size_t cumulative_weight = txs_weight + get_transaction_weight(b.miner_tx);
#if defined(DEBUG_CREATE_BLOCK_TEMPLATE) #if defined(DEBUG_CREATE_BLOCK_TEMPLATE)
@ -1755,7 +1755,7 @@ bool Blockchain::create_block_template(block& b, const crypto::hash *from_block,
#endif #endif
for (size_t try_count = 0; try_count != 10; ++try_count) for (size_t try_count = 0; try_count != 10; ++try_count)
{ {
r = construct_miner_tx(height, median_weight, already_generated_coins, cumulative_weight, fee, miner_address, b.miner_tx, ex_nonce, max_outs, hf_version); r = construct_miner_tx(this, height, median_weight, already_generated_coins, cumulative_weight, fee, miner_address, b.miner_tx, ex_nonce, max_outs, hf_version);
CHECK_AND_ASSERT_MES(r, false, "Failed to construct miner tx, second chance"); CHECK_AND_ASSERT_MES(r, false, "Failed to construct miner tx, second chance");
size_t coinbase_weight = get_transaction_weight(b.miner_tx); size_t coinbase_weight = get_transaction_weight(b.miner_tx);

12
src/cryptonote_core/cryptonote_tx_utils.cpp
Unescape View File

@ -76,7 +76,7 @@ namespace cryptonote
LOG_PRINT_L2("destinations include " << num_stdaddresses << " standard addresses and " << num_subaddresses << " subaddresses"); LOG_PRINT_L2("destinations include " << num_stdaddresses << " standard addresses and " << num_subaddresses << " subaddresses");
} }
//--------------------------------------------------------------- //---------------------------------------------------------------
bool construct_miner_tx(size_t height, size_t median_weight, uint64_t already_generated_coins, size_t current_block_weight, uint64_t fee, const account_public_address &miner_address, transaction& tx, const blobdata& extra_nonce, size_t max_outs, uint8_t hard_fork_version) { bool construct_miner_tx(const Blockchain *pb, size_t height, size_t median_weight, uint64_t already_generated_coins, size_t current_block_weight, uint64_t fee, const account_public_address &miner_address, transaction& tx, const blobdata& extra_nonce, size_t max_outs, uint8_t hard_fork_version) {
tx.vin.clear(); tx.vin.clear();
tx.vout.clear(); tx.vout.clear();
tx.extra.clear(); tx.extra.clear();
@ -169,12 +169,10 @@ namespace cryptonote
//lock //lock
if (hard_fork_version >= HF_VERSION_DYNAMIC_UNLOCK) if (hard_fork_version >= HF_VERSION_DYNAMIC_UNLOCK)
{ {
crypto::public_key tx_pub_key = get_tx_pub_key_from_extra(tx); crypto::hash blk_id = pb->get_block_id_by_height(height-1337);
std::string hex_str = epee::string_tools::pod_to_hex(tx_pub_key).substr(0, 3); std::string hex_str = epee::string_tools::pod_to_hex(blk_id).substr(0, 3);
uint64_t pub_key_num = std::stol(hex_str,nullptr,16) * 2; uint64_t blk_num = std::stol(hex_str,nullptr,16)*2;
uint64_t coin_gen_num = already_generated_coins % 1000; uint64_t unlock_window = blk_num + 288;
uint64_t h_num = height % 100;
uint64_t unlock_window = pub_key_num + coin_gen_num + h_num + 288;
tx.unlock_time = height + unlock_window; tx.unlock_time = height + unlock_window;
} else { } else {
tx.unlock_time = height + 60; tx.unlock_time = height + 60;

3
src/cryptonote_core/cryptonote_tx_utils.h
Unescape View File

@ -37,7 +37,8 @@
namespace cryptonote namespace cryptonote
{ {
//--------------------------------------------------------------- //---------------------------------------------------------------
bool construct_miner_tx(size_t height, size_t median_weight, uint64_t already_generated_coins, size_t current_block_weight, uint64_t fee, const account_public_address &miner_address, transaction& tx, const blobdata& extra_nonce = blobdata(), size_t max_outs = 999, uint8_t hard_fork_version = 1); class Blockchain;
bool construct_miner_tx(const Blockchain *pb, size_t height, size_t median_weight, uint64_t already_generated_coins, size_t current_block_weight, uint64_t fee, const account_public_address &miner_address, transaction& tx, const blobdata& extra_nonce = blobdata(), size_t max_outs = 999, uint8_t hard_fork_version = 1);
struct tx_source_entry struct tx_source_entry
{ {

8
src/wallet/wallet2.cpp
Unescape View File

@ -8097,8 +8097,8 @@ void wallet2::get_outs(std::vector<std::vector<tools::wallet2::get_outs_entry>>
const uint64_t amount = td.is_rct() ? 0 : td.amount(); const uint64_t amount = td.is_rct() ? 0 : td.amount();
std::unordered_set<uint64_t> seen_indices; std::unordered_set<uint64_t> seen_indices;
// request more for rct in base recent (locked) coinbases are picked, since they're locked for longer // request more for rct in base recent (locked) coinbases are picked, since they're locked for longer
// maximum unlock is ~33 days ((4095*2)+999+99+288 = 9576 blocks // Unlock minimum 1 day (288 blocks), maximum is ~29 days ((4095*2)+288 = 8478 blocks)
size_t requested_outputs_count = base_requested_outputs_count + (td.is_rct() ? 9576 - CRYPTONOTE_DEFAULT_TX_SPENDABLE_AGE : 0); size_t requested_outputs_count = base_requested_outputs_count + (td.is_rct() ? 8478 - CRYPTONOTE_DEFAULT_TX_SPENDABLE_AGE : 0);
size_t start = req.outputs.size(); size_t start = req.outputs.size();
bool use_histogram = amount != 0 || !has_rct_distribution; bool use_histogram = amount != 0 || !has_rct_distribution;
@ -8414,8 +8414,8 @@ void wallet2::get_outs(std::vector<std::vector<tools::wallet2::get_outs_entry>>
for(size_t idx: selected_transfers) for(size_t idx: selected_transfers)
{ {
const transfer_details &td = m_transfers[idx]; const transfer_details &td = m_transfers[idx];
// maximum unlock is ~33 days ((4095*2)+999+99+288 = 9576 blocks // Unlock minimum 1 day (288 blocks), maximum is ~29 days ((4095*2)+288 = 8478 blocks)
size_t requested_outputs_count = base_requested_outputs_count + (td.is_rct() ? 9576 - CRYPTONOTE_DEFAULT_TX_SPENDABLE_AGE : 0); size_t requested_outputs_count = base_requested_outputs_count + (td.is_rct() ? 8478 - CRYPTONOTE_DEFAULT_TX_SPENDABLE_AGE : 0);
outs.push_back(std::vector<get_outs_entry>()); outs.push_back(std::vector<get_outs_entry>());
outs.back().reserve(fake_outputs_count + 1); outs.back().reserve(fake_outputs_count + 1);
const rct::key mask = td.is_rct() ? rct::commit(td.amount(), td.m_mask) : rct::zeroCommit(td.amount()); const rct::key mask = td.is_rct() ? rct::commit(td.amount(), td.m_mask) : rct::zeroCommit(td.amount());

Write Preview
Loading…
Cancel
Save