is_coinbase bug fixed

src/CurrentBlockchainStatus.cpp

@@ -831,7 +831,7 @@ CurrentBlockchainStatus::get_searched_blk_no(const string& address,
     if (!search_thread_exist(address))
     {
         // thread does not exist
-        OMERROR << "thread for " << address << " does not exist";
+        OMERROR << "thread for " << address.substr(0,6) << " does not exist";
         return false;
     }
 
@@ -850,7 +850,7 @@ CurrentBlockchainStatus::get_known_outputs_keys(
     if (!search_thread_exist(address))
     {
         // thread does not exist
-        OMERROR << "thread for " << address << " does not exist";
+        OMERROR << "thread for " << address.substr(0,6) << " does not exist";
         return false;
     }
 
@@ -881,7 +881,8 @@ CurrentBlockchainStatus::get_xmr_address_viewkey(
     if (!search_thread_exist(address_str))
     {
         // thread does not exist
-        OMERROR << "thread for " << address_str << " does not exist";
+        OMERROR << "thread for " << address_str.substr(0,6)
+                << " does not exist";
         return false;
     }
 
@@ -903,7 +904,8 @@ CurrentBlockchainStatus::find_txs_in_mempool(
     if (searching_threads.count(address_str) == 0)
     {
         // thread does not exist
-        OMERROR << "thread for " << address_str << " does not exist";
+        OMERROR << "thread for "
+                << address_str.substr(0,6) << " does not exist";
         return false;
     }
 

src/TxSearch.cpp

@@ -627,6 +627,13 @@ while(continue_search)
 
 } // while(continue_search)
 
+}
+catch(std::exception const& e)
+{
+    OMERROR << address_prefix
+               + ": exception in TxSearch: "
+            << e.what();
+   set_exception_ptr();
 }
 catch(...)
 {
@@ -751,7 +758,6 @@ uint64_t recieve_time = mtx.first;
 const transaction& tx = mtx.second;
 
 const crypto::hash tx_hash = get_transaction_hash(tx);
-const bool coinbase = is_coinbase(tx);
 bool is_rct                 = (tx.version == 2);
 uint8_t rct_type            = (is_rct ? tx.rct_signatures.type : 0);
 
@@ -786,6 +792,7 @@ if (!outputs_identified.empty())
         = pod_to_hex(get_transaction_prefix_hash(tx));
     auto tx_pub_key_str 
         = pod_to_hex(identifier.get_tx_pub_key());
+    auto is_coinbase = cryptonote::is_coinbase(tx);
     uint64_t mixin_no {0};
     if (!is_coinbase)
         mixin_no = xmreg::get_mixin_no(tx);
@@ -840,6 +847,7 @@ if (!inputs_identfied.empty())
     auto tx_pub_key_str 
         = pod_to_hex(identifier.get_tx_pub_key());
     uint64_t mixin_no {0};
+    auto is_coinbase = cryptonote::is_coinbase(tx);
     if (!is_coinbase)
         mixin_no = xmreg::get_mixin_no(tx);
 

src/xmregcore

@@ -1 +1 @@
-Subproject commit 96d82080fc2756da0cd274982c373c8fbb14261f
+Subproject commit 9b050883c60f79a8465a2a711993c61531b2cfe8