570 Commits (35d5aa36c9b2f4bba169e5947039bf7871649ee1)

Author	SHA1	Message	Date
Riccardo Spagni	a71db6d239	Merge pull request #2981 ... b63afbaa simplewallet: detect typo for incoming_transfers options (stoffu)	7 years ago
Riccardo Spagni	bfe580787d	Merge pull request #2976 ... c765f951 simplewallet: disable donations on testnet (Matt Smith)	7 years ago
Riccardo Spagni	c951bf1f72	Merge pull request #2972 ... 586ee642 simplewallet: lock idle scope in {im,ex}port_{key_images,outputs} (moneromooo-monero)	7 years ago
Riccardo Spagni	eb617be8f4	Merge pull request #2960 ... 5cbcf0aa wallet: support for multisig seeds (moneromooo-monero)	7 years ago
Riccardo Spagni	a1a8262355	Merge pull request #2949 ... e20e489a Better definite article use (xmr-eric)	7 years ago
Riccardo Spagni	0ae3651cc9	Merge pull request #2942 ... 4f45f9da simplewallet: factor out tx exceptions (moneromooo-monero)	7 years ago
stoffu	b63afbaa99	simplewallet: detect typo for incoming_transfers options	7 years ago
Riccardo Spagni	db09247c68	Merge pull request #2926 ... 6b5bd129 Account tagging (stoffu)	7 years ago
Riccardo Spagni	2b00899bb2	Merge pull request #2920 ... bd5cce07 network_throttle: fix ineffective locking (moneromooo-monero) e0a61299 network_throttle: remove unused xxx static member (moneromooo-monero) 24f584d9 cryptonote_core: remove unused functions with off by one bugs (moneromooo-monero) b1634aa3 blockchain: don't leave dangling pointers in this (moneromooo-monero) 8e60b81c cryptonote_core: fix db leak on error (moneromooo-monero) 213e326c abstract_tcp_server2: log init_server errors as fatal (moneromooo-monero) b51dc566 use const refs in for loops for non tiny types (moneromooo-monero) f0568ca6 net_parse_helpers: fix regex error checking (moneromooo-monero) b49ddc76 check accessing an element past the end of a container (moneromooo-monero) 2305bf26 check return value for generate_key_derivation and derive_public_key (moneromooo-monero) a4240d9f catch const exceptions (moneromooo-monero) 45a1c4c0 add empty container sanity checks when using front() and back() (moneromooo-monero) 56fa6ce1 tests: fix a buffer overread in a unit test (moneromooo-monero) b4524892 rpc: guard against json parsing a non object (moneromooo-monero) c2ed8618 easylogging++: avoid buffer underflow (moneromooo-monero) 187a6ab2 epee: trap failure to parse URI from request (moneromooo-monero) 061789b5 checkpoints: trap failure to load JSON checkpoints (moneromooo-monero) ba2fefb9 checkpoints: pass std::string by const ref, not const value (moneromooo-monero) 38c8f4e0 mlog: terminate a string at last char, just in case (moneromooo-monero) d753d716 fix a few leaks by throwing objects, not newed pointers to objects (moneromooo-monero) fe568db8 p2p: use size_t for arbitrary counters instead of uint8_t (moneromooo-monero) 46d6fa35 cryptonote_protocol: sanity check chain hashes from peer (moneromooo-monero) 25584f86 cryptonote_protocol: print peer versions when unexpected (moneromooo-monero) 490a5d41 rpc: do not try to use an invalid txid in relay_tx (moneromooo-monero)	7 years ago
Riccardo Spagni	170f598ac9	Merge pull request #2918 ... f5bc7f18 simplewallet: fix default unspent_outputs output with subaddresses (moneromooo-monero)	7 years ago
Matt Smith	c765f9512c	simplewallet: disable donations on testnet	7 years ago
moneromooo-monero	586ee64209	simplewallet: lock idle scope in {im,ex}port_{key_images,outputs} ... This ensures we can't get races	7 years ago
moneromooo-monero	5cbcf0aa25	wallet: support for multisig seeds ... They are hex rather than words, because they are a lot longer than "normal" seeds, as they have to embed a lot more information	7 years ago
moneromooo-monero	4f45f9da40	simplewallet: factor out tx exceptions	7 years ago
moneromooo-monero	a4240d9ffc	catch const exceptions	7 years ago
moneromooo-monero	45a1c4c088	add empty container sanity checks when using front() and back()	7 years ago
stoffu	6b5bd129b4	Account tagging	7 years ago
xmr-eric	e20e489a64	Better definite article use	7 years ago
moneromooo-monero	98db7ee467	wallet: factor multisig info parsing	7 years ago
moneromooo-monero	31a97e761e	wallet: use raw encrypted data in multisig import/export RPC	7 years ago
moneromooo-monero	e36f5b6021	Match surae's recommendation to derive multisig keys	7 years ago
moneromooo-monero	dffa0dceaf	simplewallet: add export_raw_multisig command ... It exports raw transactions, so they may be used by other tools, for instance to be relayed to the network externally.	7 years ago
moneromooo-monero	7f4c220b70	simplewallet: add multisig to wallet type in wallet_info output	7 years ago
moneromooo-monero	265290388b	wallet: guard against partly initialized multisig wallet	7 years ago
moneromooo-monero	66e34e85b1	add multisig core test and factor multisig building blocks	7 years ago
moneromooo-monero	f4eda44ce3	N-1/N multisig	7 years ago
moneromooo-monero	fff871a455	gen_multisig: generates multisig wallets if participants trust each other	7 years ago
moneromooo-monero	4c313324b1	Add N/N multisig tx generation and signing ... Scheme by luigi1111: Multisig for RingCT on Monero 2 of 2 User A (coordinator): Spendkey b,B Viewkey a,A (shared) User B: Spendkey c,C Viewkey a,A (shared) Public Address: C+B, A Both have their own watch only wallet via C+B, a A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants) A and B watch for incoming outputs B creates "half" key images for discovered output D: I2_D = (Hs(aR)+c) * Hp(D) B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D), and sending the pubkeys with I2_D. A also creates "half" key images: I1_D = (Hs(aR)+b) * Hp(D) Then I_D = I1_D + I2_D Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction). A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D to his own generated ones where they are needed (secret row L, R). At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r, which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo). B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well). B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D to his cache, allowing him to verify spent status as well. NOTE: A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively. Otherwise, trickery like the following becomes possible: A creates viewkey a,A, spendkey b,B, and sends a,A,B to B. B creates a fake key C = zG - B. B sends C back to A. The combined spendkey C+B then equals zG, allowing B to spend funds at any time! The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature). 2 of 3 User A (coordinator) Shared viewkey a,A "spendkey" j,J User B "spendkey" k,K User C "spendkey" m,M A collects K and M from B and C B collects J and M from A and C C collects J and K from A and B A computes N = nG, n = Hs(jK) A computes O = oG, o = Hs(jM) B anc C compute P = pG, p = Hs(kM) || Hs(mK) B and C can also compute N and O respectively if they wish to be able to coordinate Address: N+O+P, A The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other needed part of the signature/key images from either of the other two. Alternatively, if secure communication exists between parties: A gives j to B B gives k to C C gives m to A Address: J+K+M, A 3 of 3 Identical to 2 of 2, except the coordinator must collect the key images from both of the others. The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it or send it back to A. N-1 of N Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around (using either the secure or insecure method). For example (ignoring viewkey so letters line up): [4 of 5] User: spendkey A: a B: b C: c D: d E: e a -> B, b -> C, c -> D, d -> E, e -> A Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with the transaction so the signers know if they should use 1 or both keys. Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each. Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning: 1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image) 2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use. You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might also be straightforward enough to support with minimal changes from N-1 format. You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc. The process is somewhat cumbersome: To create a N/N multisig wallet: - each participant creates a normal wallet - each participant runs "prepare_multisig", and sends the resulting string to every other participant - each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N) As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent: - each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant - each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants Then, a transaction may be initiated: - one of the participants runs "transfer ADDRESS AMOUNT" - this partly signed transaction will be written to the "multisig_monero_tx" file - the initiator sends this file to another participant - that other participant runs "sign_multisig multisig_monero_tx" - the resulting transaction is written to the "multisig_monero_tx" file again - if the threshold was not reached, the file must be sent to another participant, until enough have signed - the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network	7 years ago
moneromooo-monero	6d219a9250	wallet: add multisig key generation ... Scheme by luigi1111	7 years ago
moneromooo-monero	43f5269f84	Wallets now do not depend on the daemon rpc lib ... The shared RPC code is now moved off into a separate lib	7 years ago
Riccardo Spagni	b88f0879b5	Merge pull request #2873 ... 1c838552 Simplewallet.cpp: Fewer pleases in seed NOTE (xmr-eric) 3f18c642 Fix password capitalization mismatch (xmr-eric)	7 years ago
Riccardo Spagni	6c0953b15a	Merge pull request #2860 ... 3dffe71b new wipeable_string class to replace std::string passphrases (moneromooo-monero) 7a2a5741 utils: initialize easylogging++ in on_startup (moneromooo-monero) 54950829 use memwipe in a few relevant places (moneromooo-monero) 000666ff add a memwipe function (moneromooo-monero)	7 years ago
moneromooo-monero	f5bc7f1855	simplewallet: fix default unspent_outputs output with subaddresses ... If no subaddress index is given, consider all of them	7 years ago
Tobias Hoffmann	3af19c8011	set_node command, allows setting node without restart	7 years ago
Riccardo Spagni	81fb832082	Merge pull request #2833 ... b0426d4c Fixes #759 Add sanity check on restore height (Cifrado)	7 years ago
Riccardo Spagni	63f0031965	Merge pull request #2853 ... c0ae52c0 simplewallet: prevent (wrong) integrated adresses on accounts > 0 (moneromooo-monero)	7 years ago
xmr-eric	1c838552ed	Simplewallet.cpp: Fewer pleases in seed NOTE ... Monero.ts: Fewer pleases in seed NOTE Monero_it.ts: Fewer pleases in seed NOTE Monero_fr.ts: Fewer pleases in seed NOTE	7 years ago
moneromooo-monero	3dffe71b72	new wipeable_string class to replace std::string passphrases	7 years ago
Cifrado	287dde63d8	Added command descriptions	7 years ago
Riccardo Spagni	ac261d0d87	Merge pull request #2825 ... ac5cd865 simplewallet: fix typo in incoming monero message (moneromooo-monero)	7 years ago
Riccardo Spagni	a7211b5a07	Merge pull request #2822 ... 93c33985 simplewallet: translate ring size 0 to mixin 0 (default values) (moneromooo-monero)	7 years ago
Riccardo Spagni	eefd6a7878	Merge pull request #2796 ... b42ee213 Wallet: update ring size in outdated error msgs with set_default_ring_size (binaryFate)	7 years ago
Riccardo Spagni	539f511eb1	Merge pull request #2368 ... b0b7e0f0 Spend proof without txkey (stoffu)	7 years ago
moneromooo-monero	c0ae52c081	simplewallet: prevent (wrong) integrated adresses on accounts > 0	7 years ago
stoffu	b0b7e0f09a	Spend proof without txkey	7 years ago
stoffu	be1c01298a	fix for tx proof: use exception instead of error_str when signature gen failed	7 years ago
stoffu	998777ecd7	Tx proof (revised): ... - refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp - allow an arbitrary message to be signed together with txid - introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion - wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof - wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof - get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string	7 years ago
Cifrado	b0426d4cf2	Fixes #759 Add sanity check on restore height	7 years ago
moneromooo-monero	ac5cd865b2	simplewallet: fix typo in incoming monero message	7 years ago
moneromooo-monero	93c3398503	simplewallet: translate ring size 0 to mixin 0 (default values) ... Avoids turning it to a huge number	7 years ago