Unable to build wallet_api (default mixin error) #65

Related to #62, can be fixed with a PR like #63 but for wallet_api.

Got that error building libwallet to use in SuchWallet. Had no issue building libwallet against monero sources. @wowario, @jwinterm, could you please fix that? Thanks!!!

to replicate (on linux x64, release, non static)

cd wownero
mkdir build_libwallet
cd build_libwallet
cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_GUI_DEPS=ON -DCMAKE_INSTALL_PREFIX=../libwallet ../ && make && make install

error triggered

Scanning dependencies of target obj_wallet_api
[ 78%] Building CXX object src/wallet/api/CMakeFiles/obj_wallet_api.dir/wallet.cpp.o
In file included from /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/cryptonote_basic/cryptonote_basic.h:46:0,
                 from /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/cryptonote_basic/account.h:33,
                 from /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/wallet2.h:43,
                 from /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.h:35,
                 from /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp:32:
/home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/cryptonote_config.h:136:49: error: expected unqualified-id before numeric constant
 #define DEFAULT_MIXIN                           9 // ring size 10
                                                 ^
/home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp:63:25: note: in expansion of macro ‘DEFAULT_MIXIN’
     static const size_t DEFAULT_MIXIN = 9;
                         ^
/home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp: In member function ‘virtual uint32_t Monero::WalletImpl::defaultMixin() const’:
/home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp:1411:22: error: ‘class tools::wallet2’ has no member named ‘default_mixin’; did you mean ‘adjust_mixin’?
     return m_wallet->default_mixin();
                      ^~~~~~~~~~~~~
                      adjust_mixin
/home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp: In member function ‘virtual void Monero::WalletImpl::setDefaultMixin(uint32_t)’:
/home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp:1416:15: error: ‘class tools::wallet2’ has no member named ‘default_mixin’; did you mean ‘adjust_mixin’?
     m_wallet->default_mixin(arg);
               ^~~~~~~~~~~~~
               adjust_mixin
src/wallet/api/CMakeFiles/obj_wallet_api.dir/build.make:62: recipe for target 'src/wallet/api/CMakeFiles/obj_wallet_api.dir/wallet.cpp.o' failed
make[2]: *** [src/wallet/api/CMakeFiles/obj_wallet_api.dir/wallet.cpp.o] Error 1
CMakeFiles/Makefile2:2450: recipe for target 'src/wallet/api/CMakeFiles/obj_wallet_api.dir/all' failed
make[1]: *** [src/wallet/api/CMakeFiles/obj_wallet_api.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

Related to #62, can be fixed with a PR like #63 but for wallet_api. Got that error building libwallet to use in [SuchWallet](https://github.com/wownero/meta/issues/6). Had no issue building libwallet against monero sources. @wowario, @jwinterm, could you please fix that? Thanks!!! ### to replicate (on linux x64, release, non static) ``` cd wownero mkdir build_libwallet cd build_libwallet cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_GUI_DEPS=ON -DCMAKE_INSTALL_PREFIX=../libwallet ../ && make && make install ``` ### error triggered ``` Scanning dependencies of target obj_wallet_api [ 78%] Building CXX object src/wallet/api/CMakeFiles/obj_wallet_api.dir/wallet.cpp.o In file included from /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/cryptonote_basic/cryptonote_basic.h:46:0, from /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/cryptonote_basic/account.h:33, from /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/wallet2.h:43, from /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.h:35, from /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp:32: /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/cryptonote_config.h:136:49: error: expected unqualified-id before numeric constant #define DEFAULT_MIXIN 9 // ring size 10 ^ /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp:63:25: note: in expansion of macro ‘DEFAULT_MIXIN’ static const size_t DEFAULT_MIXIN = 9; ^ /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp: In member function ‘virtual uint32_t Monero::WalletImpl::defaultMixin() const’: /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp:1411:22: error: ‘class tools::wallet2’ has no member named ‘default_mixin’; did you mean ‘adjust_mixin’? return m_wallet->default_mixin(); ^~~~~~~~~~~~~ adjust_mixin /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp: In member function ‘virtual void Monero::WalletImpl::setDefaultMixin(uint32_t)’: /home/pazos/Escritorio/WOW/SuchWallet/contrib/wownero/src/wallet/api/wallet.cpp:1416:15: error: ‘class tools::wallet2’ has no member named ‘default_mixin’; did you mean ‘adjust_mixin’? m_wallet->default_mixin(arg); ^~~~~~~~~~~~~ adjust_mixin src/wallet/api/CMakeFiles/obj_wallet_api.dir/build.make:62: recipe for target 'src/wallet/api/CMakeFiles/obj_wallet_api.dir/wallet.cpp.o' failed make[2]: *** [src/wallet/api/CMakeFiles/obj_wallet_api.dir/wallet.cpp.o] Error 1 CMakeFiles/Makefile2:2450: recipe for target 'src/wallet/api/CMakeFiles/obj_wallet_api.dir/all' failed make[1]: *** [src/wallet/api/CMakeFiles/obj_wallet_api.dir/all] Error 2 Makefile:140: recipe for target 'all' failed make: *** [all] Error 2 ```

@pazos do you still get this error with v0.2.2.0