Wallet: tx verification failed: invalid output #206

When sending a transaction in "Testnet 2", I get this error:

2019-06-05 07:14:23.084	E Ringct type 5 is not allowed from v14
2019-06-05 07:14:23.085	I Transaction with id= <2e8086fb9dc895a8ab2b81c475178c921109680bb04fc3d5f69a0572fcafafb6> has at least one invalid output
2019-06-05 07:14:23.085	E Transaction verification failed: <2e8086fb9dc895a8ab2b81c475178c921109680bb04fc3d5f69a0572fcafafb6>
2019-06-05 07:14:23.085	W [on_send_raw_tx]: tx verification failed: invalid output

Related to e757efb83d/src/cryptonote_core/blockchain.cpp (L2759)

@fuwa0529 this could be related to the error you mentioned

hmm, great. Will have to check daemon log later, too drunk to be rational.

hard-coded {rct::RangeProofPaddedBulletproof, 0} in Wallet2.cpp, but hit the following error message:

2019-06-05 14:32:51.160	I [127.0.0.1:35478 INC] calling /sendrawtransaction
2019-06-05 14:32:51.161	E Insane bulletproof L size
2019-06-05 14:32:51.162	I transaction with hash 23ad125975b8e5b53ba2b42908584510bbb2dcfb4982bf1843201e8331cc6e42 not found in db
2019-06-05 14:32:51.292	I cache size: 7744 kB
2019-06-05 14:32:51.292	E Verification failure at step 1
2019-06-05 14:32:51.292	I Aggregate range proof verified failed
2019-06-05 14:32:51.292	I One transaction among this group has bad semantics, verifying one at a time
2019-06-05 14:32:51.292	I WRONG TRANSACTION BLOB, Failed to check tx <23ad125975b8e5b53ba2b42908584510bbb2dcfb4982bf1843201e8331cc6e42> semantic, rejected
2019-06-05 14:32:51.293	W [on_send_raw_tx]: tx verification failed

Error log in the daemon is reproducible.

This line seems suspiciously different:

51766d026b/src/wallet/wallet2.cpp (L9179)

vs

e757efb83d/src/wallet/wallet2.cpp (L9180)

If I swap this line with that of monero's, I get a different error:

2019-06-05 22:49:28.157 E Bad bulletproofs L size
2019-06-05 22:49:28.157 E Failed to expand transaction data
2019-06-05 22:49:28.157 I WRONG TRANSACTION BLOB, Failed to parse, rejected
2019-06-05 22:49:28.157 W [on_send_raw_tx]: tx verification failed

If I try to send a large amount, like 40, comparing to a small one, like 5, a different error:

2019-06-05 22:53:00.162 E Insane bulletproof L size
2019-06-05 22:53:00.162 I transaction with hash 1d1b6b75ee7106150703ca5dd8f2298d6e3fe97e9f719eba42b05f3129835bfe not found in db
2019-06-05 22:53:00.327 I cache size: 7744 kB
2019-06-05 22:53:00.328 E Verification failure at step 1
2019-06-05 22:53:00.328 I Aggregate range proof verified failed
2019-06-05 22:53:00.328 I One transaction among this group has bad semantics, verifying 
one at a time
2019-06-05 22:53:00.328 I WRONG TRANSACTION BLOB, Failed to check tx <1d1b6b75ee71061507
03ca5dd8f2298d6e3fe97e9f719eba42b05f3129835bfe> semantic, rejected
2019-06-05 22:53:00.328 W [on_send_raw_tx]: tx verification failed

Btw, I assume the small block reward has nothing to do with this right?

It could be this a3c020b4ee/src/ringct/rctSigs.cpp (L1235)
From v14, RCTTypeBulletproof2 is used, so this condition would give the "Aggregate range proof verified failed" error. Looks like a3c020b4ee needs to be refactored to support new RingCT format.

Yes, I think I found a fix that make it work, preparing PR.