1408 Commits (e921c3b8a35bc497ef92c4735e778e918b4c4f99)

Author	SHA1	Message	Date
selsta	cd76eb7b8c	wallet: fix unused lambda capture warning	3 years ago
SChernykh	e52802baef	Wallet2: fix optimize-coinbase for p2pool payouts ... RefreshOptimizeCoinbase was an optimization to speed up scanning of coinbase transactions before RingCT (tx version 2) where they split miner reward into multiple denominations, all to the same wallet. When RingCT was introduced, all coinbase transactions became 1 output only, so this optimization does nothing now. With p2pool, this optimization will skip scanning p2pool payouts because they use more than 1 output in coinbase transaction. Fix it by applying this optimization only to pre-RingCT transactions (version < 2).	3 years ago
luigi1111	8b9eea92f1	Merge pull request #7849 ... 6f15a0c Make sure node returns to wallet that real output is unlocked (j-berman)	3 years ago
luigi1111	1b079e5195	Merge pull request #7845 ... e1af8dc Protect client from divide by 0 caused by integer truncation (j-berman)	3 years ago
luigi1111	5812b757e0	Merge pull request #7821 ... da2955f Apply gamma distr from chain tip when selecting decoys (j-berman)	3 years ago
Kermit Alexander II	24d3d65d42	monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir	3 years ago
j-berman	e1af8dc02c	Protect client from divide by 0 caused by integer truncation	3 years ago
j-berman	da2955feae	Apply gamma distr from chain tip when selecting decoys ... - matches the paper by Miller et al to apply the gamma from chain tip, rather than after unlock time - if the gamma produces an output more recent than the unlock time, the algo packs that output into one of the first 50 spendable blocks, respecting the block density factor	3 years ago
luigi1111	62844a776d	Merge pull request #7786 ... 9c6e094 fix #7784 - deinit wallet in wallet dtor (Dusan Klinec)	3 years ago
j-berman	6f15a0c8d3	Make sure node returns to wallet that real output is unlocked	3 years ago
Dusan Klinec	13a8a576ed	trezor: try empty passphrase first ... - Try empty passphrase first when opening a wallet, as all Trezors will have passphrase enabled by default by Trezor Suite by default. This feature enables easier access to all users using disabled passphrase (or empty passhprase) - If wallet address differs from device address with empty passphrase, another opening attempt is made, without passphrase suppression, so user can enter his passhprase if using some. In this scenario, nothing changes to user, wallet opening just consumes one more call to Trezor (get wallet address with empty passphrase) - also change how m_passphrase is used. Previous version did not work well with recent passphrase entry mechanism change (made in Trezor), thus this commit fixes the behaviour).	3 years ago
luigi1111	ed506006d2	Merge pull request #7796 ... 0c6e1d3 wallet2: chunk get_outs.bin calls to avoid sanity limits (moneromooo-monero)	3 years ago
luigi1111	eeda76570c	Merge pull request #7790 ... bc8d764 wallet: rephrase error message on invalid device address (Dusan Klinec)	3 years ago
luigi1111	8c41d14ad5	Merge pull request #7788 ... f5eb2ce wallet2: Don't auto lock device on process parsed blocks (tobtoht)	3 years ago
luigi1111	9aa2d4c16e	Merge pull request #7747 ... 8cf95c8 wallet2: refresh: check error and throw before potentially breaking out of loop (tobtoht)	3 years ago
luigi1111	2d5b8a6ff7	Merge pull request #7740 ... 8cea9d8 wallet: Reset RPC Pay ID on node switch (tobtoht)	3 years ago
moneromooo-monero	0c6e1d343e	wallet2: chunk get_outs.bin calls to avoid sanity limits	3 years ago
tobtoht	f5eb2ce968	wallet2: Don't auto lock device on process parsed blocks	3 years ago
Dusan Klinec	bc8d7644d2	wallet: rephrase error message on invalid device address	3 years ago
Dusan Klinec	9c6e0941cb	fix #7784 - deinit wallet in wallet dtor	3 years ago
luigi1111	7499837a6f	Merge pull request #7661 ... 08e4497 Improve cryptonote (block and tx) binary read performance (Lee Clagett)	3 years ago
luigi1111	a1a3e970f7	Merge pull request #7662 ... 4da1112 rpc: send confirmations in get_transactions result (moneromooo-monero)	3 years ago
tobtoht	8cf95c8f29	wallet2: refresh: check error and throw before potentially breaking out of loop	3 years ago
tobtoht	8cea9d8605	wallet: Reset RPC Pay ID on node switch ... RPC pay client ID is sent with each RPC request, set a new secret every time we switch nodes to mitigate trivial correlation	3 years ago
luigi1111	628c04499b	Merge pull request #7682 ... bbdb612 Wallet2: Update 'approximate_testnet_rolled_back_blocks' (rbrunner7)	3 years ago
rbrunner7	bbdb612b51	Wallet2: Update 'approximate_testnet_rolled_back_blocks'	3 years ago
Nathan Dorfman	c57ef7f807	wallet2: Fix rescan_bc keep_ki option	3 years ago
luigi1111	9bba3f4767	Merge pull request #7651 ... c8ff1d4 monero-wallet-cli: improve error message when tx amount is zero (Elliot Wirrick)	3 years ago
mj-xmr	dc81e23e60	Split epee/string_tools.h and encapsulate boost::lexical_cast	3 years ago
moneromooo-monero	4da1112967	rpc: send confirmations in get_transactions result ... if the wallet does it, it would get a wrong result (possibly even negative) if its local chain is not synced up to the daemon's yet	3 years ago
Elliot Wirrick	c8ff1d4d23	monero-wallet-cli: improve error message when tx amount is zero	3 years ago
luigi1111	2098941ca0	Merge pull request #7635 ... 447bfae wallet2: fix unlocked mixup in light wallet mode (moneromooo-monero)	3 years ago
moneromooo-monero	447bfae2a4	wallet2: fix unlocked mixup in light wallet mode	3 years ago
moneromooo-monero	f9b5b521e8	fix serialization being different on mac ... On Mac, size_t is a distinct type from uint64_t, and some types (in wallet cache as well as cold/hot wallet transfer data) use pairs/containers with size_t as fields. Mac would save those as full size, while other platforms would save them as varints. Might apply to other platforms where the types are distinct. There's a nasty hack for backward compatibility, which can go after a couple forks.	3 years ago
luigi1111	6556c33f13	Merge pull request #7355 ... bd12984 Remove copies from foreach loops (thanks to Clang) (Lee Clagett) 1572df9 Removing unused namespace alias (Lee Clagett)	3 years ago
luigi1111	ce5800a225	Merge pull request #7346 ... 85db173 Remove unused variables in monero codebase (Kevin Barbour)	3 years ago
luigi1111	0e35d46f5e	Merge pull request #7341 ... b587ffa Stop adding more outputs than bulletproof allows (Alex Opie)	3 years ago
luigi1111	3f55f7df31	Merge pull request #7312 ... 186271e monero-wallet-cli: Added command scan_tx (Horia Mihai David)	3 years ago
Horia Mihai David	186271e5d1	monero-wallet-cli: Added command scan_tx ... To implement this feature, the wallet2::scan_tx API was implemented.	3 years ago
luigi1111	4ee301c687	Merge pull request #6986 ... ee58f4f Balance includes unconfirmed payments (woodser)	3 years ago
Kevin Barbour	85db1734e7	Remove unused variables in monero codebase ... There are quite a few variables in the code that are no longer (or perhaps never were) in use. These were discovered by enabling compiler warnings for unused variables and cleaning them up. In most cases where the unused variables were the result of a function call the call was left but the variable assignment removed, unless it was obvious that it was a simple getter with no side effects.	3 years ago
Lee Clagett	1572df9e26	Removing unused namespace alias	3 years ago
Alex Opie	520ce1ca81	Attempt to carve the fee from a partial payment early ... Do this for both the estimate and actual fee. #7337	3 years ago
Alex Opie	b587ffa1fd	Stop adding more outputs than bulletproof allows ... If more outputs are requested, they are split across multiple transactions. #7322	3 years ago
Lee Clagett	08e4497c6e	Improve cryptonote (block and tx) binary read performance	3 years ago
moneromooo-monero	d2fda6c25f	restrict public node checks a little ... do not include blocked hosts in peer lists or public node lists by default, warn about no https on clearnet and about untrusted peers likely being spies	3 years ago
woodser	ee58f4f766	Balance includes unconfirmed payments	4 years ago
Lee Clagett	7414e2bac1	Change epee binary output from std::stringstream to byte_stream	4 years ago
Alexander Blair	6b8db83149	Merge pull request #7043 ... 17c537039 wallet2: check imported multisig curve points are in main subgroup (Crypto City)	3 years ago
selsta	89bbb802c0	wallet2: set propagation timeout to current max timeout	4 years ago
Alexander Blair	438442ace0	Merge pull request #6890 ... ec14e4b8c wallet2: skip reorgs exceeding max-reorg-depth wallet setting (xiphon)	4 years ago
Crypto City	17c5370398	wallet2: check imported multisig curve points are in main subgroup	4 years ago
xiphon	fc2f97177b	wallet2: wait for propagation timeout before marking tx as failed	4 years ago
xiphon	ec14e4b8cd	wallet2: skip reorgs exceeding max-reorg-depth wallet setting	4 years ago
moneromooo-monero	b6c4f8cd54	fix a couple bugs found by OSS-fuzz ... - index out of bounds when importing outputs - accessing invalid CLSAG data	4 years ago
luigi1111	2b1488ef6f	Merge pull request #6793 ... de9a9fb update error message 'No unlocked balance in the specified account' (woodser)	4 years ago
TheCharlatan	80e535c95a	wallet2: adapt to deterministic unlock time	4 years ago
luigi1111	9bba1a24ea	Merge pull request #6815 ... ef4325f wallet2: fix tx sanity check triggering on pre-rct outputs (monermooo-monero)	4 years ago
moneromooo-monero	ef4325fd41	wallet2: fix tx sanity check triggering on pre-rct outputs	4 years ago
Reinaldulin	a3844e257e	Fix typo in command line argument description	4 years ago
luigi1111	fd657c7706	Merge pull request #6798 ... 4e44306 enable CLSAG support for Trezor client (ph4r05)	4 years ago
Dusan Klinec	4e4430603f	enable CLSAG support for Trezor client	4 years ago
luigi1111	ee0b02d0db	Merge pull request #6757 ... 6a37da8 threadpool: guard against exceptions in jobs, and armour plating (moneromooo-monero)	4 years ago
woodser	de9a9fb340	update error message "No unlocked balance in the specified account"	4 years ago
moneromooo-monero	6a37da837e	threadpool: guard against exceptions in jobs, and armour plating ... Those would, if uncaught, exit run and leave the waiter to wait indefinitely for the number of active jobs to reach 0	4 years ago
Sarang Noether	fa06c39d97	Bind signature to full address and signing mode	4 years ago
moneromooo-monero	743608ec16	wallet: allow signing a message with spend or view key	4 years ago
moneromooo-monero	82ee01699c	Integrate CLSAGs into monero ... They are allowed from v12, and MLSAGs are rejected from v13.	4 years ago
Alexander Blair	4fe2858b4d	Merge pull request #6746 ... 20f603c6b Fix broken multisig pubkey sorting (Jason Rhinelander)	4 years ago
Alexander Blair	a06c83db73	Merge pull request #6752 ... 85899230d simplewallet: allow setting tx keys when sending to a subaddress (moneromooo-monero) e916201f1 wallet2: fix setting tx keys when another is already set (moneromooo-monero)	4 years ago
Alexander Blair	42519b48a7	Merge pull request #6731 ... db5d6e460 wallet2: fix wrong name when checking RPC cost (moneromooo-monero)	4 years ago
Alexander Blair	bad5d8d6f0	Merge pull request #6690 ... 7175dcb10 replace most boost serialization with existing monero serialization (moneromooo-monero)	4 years ago
luigi1111	765db1ae7a	Revert "Use domain-separated ChaCha20 for in-memory key encryption" ... This reverts commit 921dd8dde5.	4 years ago
moneromooo-monero	7175dcb107	replace most boost serialization with existing monero serialization ... This reduces the attack surface for data that can come from malicious sources (exported output and key images, multisig transactions...) since the monero serialization is already exposed to the outside, and the boost lib we were using had a few known crashers. For interoperability, a new load-deprecated-formats wallet setting is added (off by default). This allows loading boost format data if there is no alternative. It will likely go at some point, along with the ability to load those. Notably, the peer lists file still uses the boost serialization code, as the data it stores is define in epee, while the new serialization code is in monero, and migrating it was fairly hairy. Since this file is local and not obtained from anyone else, the marginal risk is minimal, but it could be migrated later if needed. Some tests and tools also do, this will stay as is for now.	4 years ago
Alexander Blair	01b512f3a9	Merge pull request #6716 ... 76c16822d wallet2_api: implement runtime proxy configuration (xiphon)	4 years ago
Alexander Blair	f40b9e34e0	Merge pull request #6715 ... 3d6bc0a68 wallet2: throw a error on wallet initialization failure (xiphon)	4 years ago
Alexander Blair	8f02e7a7fc	Merge pull request #6632 ... ef694d028 fix warning by removing std::move() on temporary http_client object (woodser)	4 years ago
Alexander Blair	6d29ee6c52	Merge pull request #6493 ... 921dd8dde Use domain-separated ChaCha20 for in-memory key encryption (Sarang Noether)	4 years ago
moneromooo-monero	85899230d1	simplewallet: allow setting tx keys when sending to a subaddress ... The tx key derivation is different then	4 years ago
Sarang Noether	921dd8dde5	Use domain-separated ChaCha20 for in-memory key encryption	4 years ago
Sarang Noether	6bfcd31015	Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests.	4 years ago
moneromooo-monero	e916201f12	wallet2: fix setting tx keys when another is already set ... insert doesn't actually insert if another element with the same key is already in the map	4 years ago
Jason Rhinelander	20f603c6be	Fix broken multisig pubkey sorting ... The sort predicate is a boolean ordered-before value, but these are returning the memcmp value directly, and thus returns true whenever the pubkeys aren't equal. This means: - it isn't actually sorting. - it can (and does) segfault for some inputs.	4 years ago
moneromooo-monero	db5d6e4602	wallet2: fix wrong name when checking RPC cost	4 years ago
xiphon	76c16822d0	wallet2_api: implement runtime proxy configuration	4 years ago
xiphon	3d6bc0a680	wallet2: throw a error on wallet initialization failure	4 years ago
Alexander Blair	a0d179e528	Merge pull request #6512 ... 5ef0607da Update copyright year to 2020 (SomaticFanatic)	4 years ago
luigi1111	340e1943ac	Merge pull request #6587 ... 94befec fix typo in pick_preferred_rct_inputs (Parean)	4 years ago
luigi1111	c4f4091dd4	Merge pull request #6561 ... c17fe81 wallet2: fix multisig data clearing stomping on a vector (moneromooo-monero)	4 years ago
luigi1111	3a577f1ce7	Merge pull request #6525 ... 86cf811 simplewallet: don't complain about incoming payment ids on change (moneromooo-monero)	4 years ago
woodser	ef694d028f	fix warning by removing std::move() on temporary http_client object	4 years ago
Lee Clagett	7aeb503547	Fix boost <1.60 compilation and fix boost 1.73+ warnings	4 years ago
Denis Smirnov	94befecb05	fix typo in pick_preferred_rct_inputs	4 years ago
moneromooo-monero	c17fe815a2	wallet2: fix multisig data clearing stomping on a vector	4 years ago
moneromooo-monero	86cf811a39	simplewallet: don't complain about incoming payment ids on change	4 years ago
luigi1111	4c2f78aeeb	Merge pull request #6506 ... 42e1484 wallet2: fix keys file deserialization exception handling (xiphon)	4 years ago
SomaticFanatic	5ef0607da6	Update copyright year to 2020 ... Update copyright year to 2020	4 years ago
luigi1111	3de804f1e9	Merge pull request #6485 ... 7a8c1ee wallet2: fix subaddress expansion when receiving monero (moneromooo-monero)	4 years ago
luigi1111	9e3f72c375	Merge pull request #6480 ... 4f489fa wallet2: check_connection return false on get_version status != OK (xiphon)	4 years ago
luigi1111	6d1f3c9acd	Merge pull request #6467 ... 8b655de simplewallet: report timestamp based expected unlock time on balance (moneromooo-monero)	4 years ago
luigi1111	b4023dcfc5	Merge pull request #6441 ... 613071f use memwipe on secret k/alpha values (moneromooo-monero)	4 years ago
xiphon	42e14840fb	wallet2: fix keys file deserialization exception handling	4 years ago
luigi1111	c9b800a787	Merge pull request #6446 ... e509ede trezor: adapt to new passphrase mechanism (ph4r05)	4 years ago
moneromooo-monero	7a8c1eece9	wallet2: fix subaddress expansion when receiving monero	4 years ago
Dusan Klinec	e509ede2aa	trezor: adapt to new passphrase mechanism ... - choice where to enter passphrase is now made on the host - use wipeable string in the comm stack - wipe passphrase memory - protocol optimizations, prepare for new firmware version - minor fixes and improvements - tests fixes, HF12 support	4 years ago
xiphon	4f489fa6a2	wallet2: check_connection return false on get_version status != OK	4 years ago
moneromooo-monero	8b655de8ed	simplewallet: report timestamp based expected unlock time on balance	4 years ago
woodser	87d75584e8	Allow wallet2.h to run in WebAssembly ... - Add abstract_http_client.h which http_client.h extends. - Replace simple_http_client with abstract_http_client in wallet2, message_store, message_transporter, and node_rpc_proxy. - Import and export wallet data in wallet2. - Use #if defined __EMSCRIPTEN__ directives to skip incompatible code.	4 years ago
moneromooo-monero	613071f4fa	use memwipe on secret k/alpha values ... Reported by UkoeHB_ and sarang	4 years ago
luigi1111	bce050ee78	Merge pull request #6394 ... 69b5992 simplewallet: new 'address one-off <major> <minor>' command (moneromooo-monero)	4 years ago
moneromooo-monero	69b5992296	simplewallet: new "address one-off <major> <minor>" command	4 years ago
luigi1111	cfc0f4a7fa	Merge pull request #6351 ... 81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd) 5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd) 3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)	4 years ago
luigi1111	081d49c59f	Merge pull request #6338 ... 80d5320 Hash domain separation (SarangNoether)	4 years ago
luigi1111	ab802b4b80	Merge pull request #6321 ... 1a6e7bd wallet2: mention --daemon-ssl-allow-any-cert in --proxy error msg (xiphon)	4 years ago
Sarang Noether	80d5320fff	Hash domain separation	4 years ago
xiphon	6d6af701ec	cryptonote_basic: drop unused verification_context::m_not_rct field	4 years ago
luigi1111	f9de65b546	Merge pull request #6304 ... 2e9d1e6 wallet2: fix store-tx-info loading (moneromooo-monero)	4 years ago
luigi1111	d0065f3063	Merge pull request #6302 ... dab604e wallet2_api: implement estimateTransactionFee (xiphon)	4 years ago
Alexander Blair	72262b348a	Merge pull request #6299 ... 9c1f970b wallet2: remember daemon address overrides when loading a new wallet (moneromooo-monero)	4 years ago
Alexander Blair	5780594202	Merge pull request #6296 ... 50e59cfa wallet2: reject zero keys in json input (moneromooo-monero)	4 years ago
Alexander Blair	8cb005b39c	Merge pull request #6289 ... ffe7165e wallet: reroll fake outs selection on local tx_sanity_check failure (xiphon)	4 years ago
Alexander Blair	5ba6eef272	Merge pull request #6288 ... 0349347e ringdb: use a different iv for key and data in rings table (moneromooo-monero) 7b882087 simplewallet: reword mixin in user message in terms of ring size (moneromooo-monero) f507a43a wallet2: do not remove known rings when a tx fails (moneromooo-monero)	4 years ago
Alexander Blair	d500bbe68f	Merge pull request #6268 ... a6c24412 wallet: fix exceptions getting the hash of a pruned tx (moneromooo-monero)	4 years ago
Lee Clagett	5fcc23ae0a	Move hex->bin conversion to monero copyright files and with less includes	4 years ago
moneromooo-monero	9c1f970b82	wallet2: remember daemon address overrides when loading a new wallet	4 years ago
Alexander Blair	da617ac1b0	Merge pull request #6238 ... f717d593 wallet2: guard against race with multiple decrypt_keys users (moneromooo-monero)	4 years ago
Alexander Blair	a6cf4b09e7	Merge pull request #6235 ... 5cbb17b9 wallet2: fix hang in wallet refresh (moneromooo-monero)	4 years ago
luigi1111	2de1137e60	Merge pull request #6194 ... 316ab7b wallet2: better error when restoring a wallet with the wrong keys (moneromooo-monero)	4 years ago
luigi1111	22a0367398	Merge pull request #6190 ... 096a9db Wallet: Distingush amounts for a single subaddress (tmoravec)	4 years ago
xiphon	1a6e7bd40f	wallet2: mention --daemon-ssl-allow-any-cert in --proxy error msg	4 years ago
Alexander Blair	995f34b538	Merge pull request #6103 ... 4b384003 wallet2: don't try to lock an empty filename (moneromooo-monero)	4 years ago
Alexander Blair	3b224bb99d	Merge pull request #6069 ... d64e5aa7 wallet: allow message sign/verify for subaddresses (moneromooo-monero)	4 years ago
moneromooo-monero	dd8c6b1703	wallet: do not split integrated addresses in address book api	4 years ago
xiphon	dab604e010	wallet2_api: implement estimateTransactionFee	4 years ago
Alexander Blair	159c78758a	Merge pull request #6154 ... 3b419333 wallet: don't issue node rpc proxy requests in '--offline' mode (xiphon)	4 years ago
moneromooo-monero	2e9d1e6e1f	wallet2: fix store-tx-info loading ... The backward compatibility code was always setting it to 1 in modern wallets since store_tx_keys was not present and thus assumed to be 1 by default. Reported by SeventhAlpaca	4 years ago
moneromooo-monero	50e59cfada	wallet2: reject zero keys in json input ... Because the user might do this for reasons unknown. Values beyond l-1 will be reduced, so are accepted. Reported by who-biz.	4 years ago
xiphon	ffe7165ebf	wallet: reroll fake outs selection on local tx_sanity_check failure	4 years ago
Alexander Blair	d024695772	Merge pull request #6105 ... 0de8a0d3 wallet_rpc_server: new estimate_tx_size_and_weight RPC (moneromooo-monero)	4 years ago
Tadeas Moravec	096a9dbdf9	Wallet: Distingush amounts for a single subaddress ... Adding a new `amounts` field ot the output of `get_transfers` RPC method. This field specifies individual payments made to a single subaddress in a single transaction, e.g., made by this command: transfer <addr1> <amount1> <addr1> <amount2>	4 years ago
moneromooo-monero	f507a43a23	wallet2: do not remove known rings when a tx fails ... Even if it fails, the ring composition is known to a potential adversary, and so we should reuse the same ring next time	4 years ago
moneromooo-monero	d64e5aa719	wallet: allow message sign/verify for subaddresses	4 years ago
moneromooo-monero	a6c24412e5	wallet: fix exceptions getting the hash of a pruned tx	4 years ago
moneromooo-monero	f717d5936c	wallet2: guard against race with multiple decrypt_keys users ... If more than one thread wants to make sure of the spend secret key, then we decrypt on the first caller and reencrypt on the last caller, otherwise we could use an invalid secret key.	4 years ago
moneromooo-monero	5cbb17b946	wallet2: fix hang in wallet refresh ... If the hashes received would move the current blockchain past the stop point, the short history would not be updated, since we do not expect another loop, but the daemon might return earlier hashes, causing the end index to not be enough to reach the threshold and this require another loop, which will download the same hashes and cause an infinite loop.	4 years ago
luigi1111	b4e1dc83d2	Merge pull request #6057 ... 3b8dcc2 wallet2: make keys unlocker reentrant (moneromooo-monero)	4 years ago
moneromooo-monero	316ab7b56e	wallet2: better error when restoring a wallet with the wrong keys	5 years ago
xiphon	3b41933335	wallet: don't issue node rpc proxy requests in '--offline' mode	5 years ago
moneromooo-monero	0de8a0d37d	wallet_rpc_server: new estimate_tx_size_and_weight RPC	5 years ago
moneromooo-monero	4b38400336	wallet2: don't try to lock an empty filename	5 years ago