moneromooo-monero
4ee095c200
p2p: don't connect to more than one IP per class B if we can
5 years ago
moneromooo-monero
c2238327d0
keccak: guard against misaligned memory accesses on ARM
...
The code generated is exactly the same as the direct access
one on x86_64
5 years ago
moneromooo-monero
a96c1a46d4
cryptonote_protocol: drop peers we can't download from when syncing
...
Any peer that's behind us while syncing is useless to us (though
not to them). This ensures that we don't get our peer slots filled
with peers that we can't use. Once we've synced, we can connect
to them and they can then sync off us if they want.
5 years ago
moneromooo-monero
ab361df2cd
p2p: add a few missing connection close calls
5 years ago
luigi1111
9d7107c870
Merge pull request #5663
...
5d6b43b
core: fix --prune-blockchain not pruning if no blockchain exists (moneromooo-monero)
5 years ago
luigi1111
59ba0eee69
Merge pull request #5650
...
3c071d2
blockchain: silence an error getting blocks for pruned nodes (moneromooo-monero)
5 years ago
luigi1111
591c72613b
Merge pull request #5647
...
2ff99fb
db_lmdb: commit pruning txn at checkpoints (moneromooo-monero)
5 years ago
selene
c393e824d6
CryptonightR_JIT: fix return value on error
...
The value was positive rather than zero, but the caller only
checks for negative errors
5 years ago
Martijn Otto
c164f9037e
Remove unnecessary m_check_txin_table, fix const correctness
5 years ago
Jethro Grassie
6560bfa64c
rpc: get_block_template add optional extra_nonce
...
Circumvents the need to create a new blockhashing blob when you already
know the data you want to set in the extra_nonce (so use this instead of
reserve_size).
5 years ago
moneromooo-monero
8be5fea1de
simplewallet: optional all flag to export_outputs/export_key_images
5 years ago
moneromooo-monero
bcd2da76cd
miner: fix --bg-mining-enable description
5 years ago
Jethro Grassie
dc8b7a88bd
zmq: MacPorts latest fix
5 years ago
moneromooo-monero
c8709fe52f
wallet: do not print log settings when unset
...
Coverity 199721
5 years ago
luigi1111
633f14b976
Merge pull request #5681
...
037f94c
Remove Xiala.net from the list of dns resolvers (tobtoht)
5 years ago
luigi1111
2db997828a
Merge pull request #5678
...
15c699f
rpc: set sanity_check_failed to false when successful (stoffu)
5 years ago
luigi1111
393c33f86c
Merge pull request #5675
...
da3e20e
tx_sanity_check: relax the median check a lot (moneromooo-monero)
5 years ago
moneromooo-monero
4237707d3e
p2p: don't forget pruning seed or public RPC port when updating peers
...
Older nodes don't pass that information around
5 years ago
Michal vel m@lbit
1db5357c7b
rpc headers fix
5 years ago
moneromooo-monero
a604241ef6
simplewallet: don't ask about mining when running a command line
...
This is likely to be done via a script
5 years ago
moneromooo-monero
3768db227c
p2p: add a reference to Cao, Tong et al. for the last_seen changes
...
"Exploring the Monero Peer-to-Peer Network". https://eprint.iacr.org/2019/411
5 years ago
tobtoht
037f94c54e
Remove Xiala.net from the list of dns resolvers
...
It is down permanently. See: https://xiala.net/
"Ende November 2018 werden alle Dienste von xiala.net abgeschaltet."
5 years ago
stoffu
15c699f0a6
rpc: set sanity_check_failed to false when successful
5 years ago
moneromooo-monero
da3e20ee01
tx_sanity_check: relax the median check a lot
...
we don't want to prevent bona fide txes, just obvious bad ones
5 years ago
moneromooo-monero
098aadf084
p2p: close the right number of connections on setting max in/out peers
5 years ago
moneromooo-monero
fcbf7b3f74
p2p: propagate out peers limit to payload handler
5 years ago
Dusan Klinec
097cca59c1
wallet_api: catch getTxKey exception
...
- getTxKey method throws an exception, e.g., when user declines txKey export
5 years ago
moneromooo-monero
b2bfcab618
wallet2: fix change subaddress mixup when sending pre rct outputs
5 years ago
moneromooo-monero
5d6b43b672
core: fix --prune-blockchain not pruning if no blockchain exists
5 years ago
Dusan Klinec
f074b6b571
device: show address on device display
...
- Trezor: support for device address display (subaddress, integrated address)
- Wallet::API support added
- Simplewallet:
- address device [<index>]
- address new <label> // shows address on device also
- integrated_address [device] <payment_id|address> // new optional "device" arg to display also on the device
5 years ago
Dusan Klinec
64fb0f872a
device: tx_key caching fixed, store recovered txkey
5 years ago
Howard Chu
8ccc30b163
Fix --restore-date usage
...
The wallet was ignoring --restore-height and --restore-date params and
prompting for them again.
5 years ago
moneromooo-monero
3c071d203f
blockchain: silence an error getting blocks for pruned nodes
...
This happens often when a pre-pruning node asks a pruned node
for data it does not have
5 years ago
Howard Chu
a182df21d0
Bans for RPC connections
...
Make bans control RPC sessions too. And auto-ban some bad requests.
Drops HTTP connections whenever response code is 500.
5 years ago
moneromooo-monero
2ff99fb47f
db_lmdb: commit pruning txn at checkpoints
...
to avoid errors when the txn is too large
5 years ago
Riccardo Spagni
6335509727
Merge pull request #5641
...
633f1542
prep for 0.14.1 release (Riccardo Spagni)
5 years ago
Riccardo Spagni
633f1542e2
prep for 0.14.1 release
5 years ago
moneromooo-monero
2eef90d6ef
rpc: restrict the recent cutoff size in restricted RPC mode
5 years ago
moneromooo-monero
0564da5fdc
ensure no NULL is passed to memcpy
...
NULL is valid when size is 0, but memcpy uses nonnull attributes,
so let's not poke the bear
5 years ago
moneromooo-monero
1387549e90
serialization: check stream good flag at the end
...
just in case
5 years ago
moneromooo-monero
a00cabd4f3
tree-hash: allocate variable memory on heap, not stack
...
Large amounts might run out of stack
Reported by guidov
5 years ago
moneromooo-monero
f215219252
cryptonote: throw on tx hash calculation error
5 years ago
moneromooo-monero
db2b9fba65
serialization: fail on read_varint error
5 years ago
moneromooo-monero
68ad548193
cryptonote_protocol: fix another potential P2P DoS
...
When asking for txes in a fluffy transaction, one might ask
for the same (large) tx many times
5 years ago
moneromooo-monero
1cc61018e5
cryptonote_protocol: expand basic DoS protection
...
Count transactions as well
5 years ago
anonimal
8f66b7053a
cryptonote_protocol_handler: prevent potential DoS
...
Essentially, one can send such a large amount of IDs that core exhausts
all free memory. This issue can theoretically be exploited using very
large CN blockchains, such as Monero.
This is a partial fix. Thanks and credit given to CryptoNote author
'cryptozoidberg' for collaboration and the fix. Also thanks to
'moneromooo'. Referencing HackerOne report #506595 .
5 years ago
moneromooo-monero
69f9420489
core: do not complain about low block rate if disconnected
...
In that case, we'll still keep the "Monero is now disconnected
from the network" near the end of the log
5 years ago
moneromooo-monero
b712ae0af2
rpc: work around a GCC 7.4.0 (at least) bug
...
In static member function ‘static boost::optional<cryptonote::rpc::output_distribution_data> cryptonote::rpc::RpcHandler::get_output_distribution(const std::function<bool(long unsigned int, long unsigned int, long unsigned int, long unsigned int&, std::vector<long unsigned int>&, long unsigned int&)>&, uint64_t, uint64_t, uint64_t, const std::function<crypto::hash(long unsigned int)>&, bool, uint64_t)’:
cc1plus: warning: ‘void* __builtin_memset(void*, int, long unsigned int)’: specified size 18446744073709551536 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
5 years ago
moneromooo-monero
03aa14ec87
tx_sanity_check: don't print an error when not enough outs to check
5 years ago
moneromooo-monero
14881094af
rpc: fix get_transactions getting v1 txes from the txpool
...
It would try to get their prunable hash, but v1 txes don't have one
5 years ago
luigi1111
fd0cf689dd
Merge pull request #5619
...
f2f207d
miner: fix double free of thread attributes (ston1th)
5 years ago
Your Name
6b41bd8eb5
Delete more include string.h
5 years ago
xiphon
b8cfa92b7e
rpc: implement set_bootstrap_daemon method
5 years ago
moneromooo-monero
35c20c4332
Fix GCC 9.1 build warnings
...
GCC wants operator= aand copy ctor to be both defined, or neither
5 years ago
ston1th
f2f207d635
miner: fix double free of thread attributes
...
issue: #5568
5 years ago
moneromooo-monero
2cbe75661c
p2p: fix GCC 9.1 crash
5 years ago
moneromooo-monero
068fa1ca5c
p2p: delay IGP probing on startup
...
We might have external access without having to do this
5 years ago
moneromooo-monero
c820e1839f
simplewallet: print errors on exceptions creating wallets
...
Exceptions would otherwise terminate the process silently
5 years ago
xiphon
cf8cb6873a
rpc: use ip address string representation for peer::host field
5 years ago
Howard Chu
dd58057126
Remember RPC version on initial connect
...
Don't keep asking for it on an intact connection
Wallet is too chatty over the wire
5 years ago
Riccardo Spagni
62d32e955a
Merge pull request #5577
...
f950517a
core: update pruning if using --prune-blockchain on a pruned blockchain (moneromooo-monero)
5 years ago
Riccardo Spagni
7e417dd408
Merge pull request #5571
...
35da33be
blockchain: do not try to pop blocks down to the genesis block (moneromooo-monero)
4b51f9a3
core: do not commit half constructed batch db txn (moneromooo-monero)
5 years ago
Riccardo Spagni
14d3295649
Merge pull request #5561
...
9bfa4c20
Fix allow any cert mode in wallet rpc when configured over rpc (Lee Clagett)
3544596f
Add ssl_options support to monerod's rpc mode. (Lee Clagett)
c9aaccf3
Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works. (Lee Clagett)
5 years ago
Riccardo Spagni
fccfc1aa25
Merge pull request #5555
...
b6830db2
Fix #5553 (Howard Chu)
5 years ago
Jethro Grassie
343c0b4255
add a command line option to disable ZMQ server
5 years ago
moneromooo-monero
880ebfdeea
daemon: add more chain specific info in alt_chain_info
5 years ago
moneromooo-monero
2aa11341fc
daemon: display peer address type in print_cn
5 years ago
moneromooo-monero
fcfcc3ac86
rpc: in/out peers can now return the setting's value
5 years ago
wowario
cd720c7e0b
add cumulative difficulty to diff command
5 years ago
Jesus Ramirez
270a3ae58b
Unused private member m_miner_address
5 years ago
moneromooo-monero
f950517a08
core: update pruning if using --prune-blockchain on a pruned blockchain
...
Avoids a massive amount of spurious warnings if the last update before
the daemon exited was a while ago and the daemon was syncing
5 years ago
xiphon
577324a954
wallet_manager: omit redundant disconnect, drop unused variable
5 years ago
moneromooo-monero
35da33bea9
blockchain: do not try to pop blocks down to the genesis block
5 years ago
moneromooo-monero
4b51f9a34f
core: do not commit half constructed batch db txn
5 years ago
moneromooo-monero
162c3e18ec
blockchain_export: allow exporting blocks.dat format from pruned
...
We don't need any of the pruned data for this
5 years ago
moneromooo-monero
c07bbd5c04
daemon: fix "never seen before" time span display for peers
5 years ago
Lee Clagett
9bfa4c20ca
Fix allow any cert mode in wallet rpc when configured over rpc
5 years ago
Lee Clagett
3544596f9f
Add ssl_options support to monerod's rpc mode.
5 years ago
Lee Clagett
c9aaccf346
Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works.
5 years ago
Howard Chu
b6830db2d4
Fix #5553
...
Make sure the tip hash still matches the cached block
5 years ago
moneromooo-monero
915f59e3c0
wallet: add unlock_time details to show_transfers
...
also add a note when receiving the tx, because the user
might not notice the "XXX blocks to unlock" in the balance.
5 years ago
Riccardo Spagni
e8487fa46b
Merge pull request #5539
...
3f612cda
Changed odd bullet point to low level header (Rohaq)
af9bc4ec
Used subeaders to avoid slightly wonky looking formatting (Rohaq)
1873af35
Made code block usage consistent across all .md files (Rohaq)
68103075
Updated Copyright notice (Rohaq)
39bd157f
Added Table of Contents to main README.md (Rohaq)
5 years ago
Riccardo Spagni
5e80b3c3ef
Merge pull request #5535
...
e1016bce
password: do not use line input on windows (moneromooo-monero)
5 years ago
luigi1111
1607419e38
Merge pull request #5538
...
615f287
wallet: fix certificate fingerprint length check (moneromooo-monero)
5 years ago
luigi1111
eedf5106f5
Merge pull request #5532
...
46244dd
wallet_rpc_server: use original addresses in destinations in get_transfers (moneromooo-monero)
5 years ago
luigi1111
5a67ff2b32
Merge pull request #5526
...
1e8f3f6
rpc: fail update RPC when running offline (moneromooo-monero)
5 years ago
luigi1111
266f68be32
Merge pull request #5512
...
d47292e
error: fix compile error on windows with depends (moneromooo-monero)
5 years ago
Rohaq
1873af35bf
Made code block usage consistent across all .md files
5 years ago
moneromooo-monero
615f287aec
wallet: fix certificate fingerprint length check
...
Fixed by crCr62U0
5 years ago
moneromooo-monero
e1016bce14
password: do not use line input on windows
...
This keeps its builtin command editing away
Thanks iDunk for testing on Windows
5 years ago
dsc
4c666141e3
expose set/get walletcache attribute functionality in wallet api
5 years ago
moneromooo-monero
46244dd08c
wallet_rpc_server: use original addresses in destinations in get_transfers
...
And add them for pending transfers, where they were missing
5 years ago
moneromooo-monero
6abaaaa994
remove obsolete save_graph skeleton code
5 years ago
moneromooo-monero
1e8f3f66bf
rpc: fail update RPC when running offline
5 years ago
moneromooo-monero
4228ee0b9e
daemon: add optional arguments to alt_chain_info
...
>N limits display to alt chains with more than N blocks
-N limits display to alt chains younger than N blocks
5 years ago
moneromooo-monero
0605406714
daemon: sort alt chains by height
5 years ago
moneromooo-monero
06b8f29992
blockchain: keep alternative blocks in LMDB
...
Alternative blocks are cleared on startup unless --keep-alt-blocks
is passed on the command line
5 years ago
Riccardo Spagni
f64f59627d
Merge pull request #5510
...
e9809382
fix wide difficulty conversion with some versions of boost (moneromooo-monero)
5 years ago
Riccardo Spagni
97cb1c9436
Merge pull request #5508
...
1c44e658
wallet2: reject standalone short payment IDs in monero: URI API (moneromooo-monero)
5 years ago
Riccardo Spagni
a22a8b0f2b
Merge pull request #5505
...
7e5158aa
mnemonics: fix 4 byte UTF-8 rewriting (moneromooo-monero)
5 years ago
Riccardo Spagni
c20221f290
Merge pull request #5503
...
ccc1e311
wallet_rpc_server: reject standalone short payment id in address book (moneromooo-monero)
5 years ago
Riccardo Spagni
ebb1c03e8c
Merge pull request #5501
...
b4ca72dd
wallet2: fix infinite loop picking outputs in corner case (moneromooo-monero)
5 years ago
Riccardo Spagni
2d04b0e500
Merge pull request #5499
...
a4c4a2d8
blockchain: keep a rolling long term block weight median (moneromooo-monero)
5 years ago
Riccardo Spagni
9d91301faa
Merge pull request #5496
...
0eb0d6b8
rpc: improve get_output_distribution (moneromooo-monero)
5 years ago
Riccardo Spagni
cf8319602d
Merge pull request #5481
...
28a7d315
p2p: do not send last_seen timestamp to peers (moneromooo-monero)
5 years ago
moneromooo-monero
e4d100b062
wallet2: don't wait a day before using new version fees
...
30 blocks should be more than enough to drain the txpool of
transactions made with the old fee scheme
5 years ago
moneromooo-monero
bc94ba4d14
wallet: distinguish between empty and absent attributes
5 years ago
moneromooo-monero
d47292eb3d
error: fix compile error on windows with depends
...
state_not_recoverable is not defined there
5 years ago
moneromooo-monero
a4c4a2d8aa
blockchain: keep a rolling long term block weight median
5 years ago
Riccardo Spagni
77f9bfa4d5
Merge pull request #5493
...
5e0da6fb
change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 (moneromooo-monero)
5 years ago
Riccardo Spagni
52eb454d7b
Merge pull request #5491
...
98fb98f9
wallet_rpc_server: adding missing return on error in set_daemon (moneromooo-monero)
9074c0d8
wallet_rpc_server: return false on error in set_log_categories (moneromooo-monero)
968848a7
wallet_rpc_server: fix crash in validate_address if no wallet is loaded (moneromooo-monero)
5 years ago
Riccardo Spagni
efd2412e77
Merge pull request #5489
...
64983fce
wallet2: default to trying to keep 5 outputs of 2+ monero (moneromooo-monero)
5 years ago
Riccardo Spagni
08ab0cbdda
Merge pull request #5476
...
0aaf5e2a
device/trezor: device sorting and filtering improved (Dusan Klinec)
5 years ago
moneromooo-monero
e980938210
fix wide difficulty conversion with some versions of boost
5 years ago
moneromooo-monero
1c44e65863
wallet2: reject standalone short payment IDs in monero: URI API
5 years ago
moneromooo-monero
7e5158aa97
mnemonics: fix 4 byte UTF-8 rewriting
5 years ago
moneromooo-monero
ccc1e311dc
wallet_rpc_server: reject standalone short payment id in address book
5 years ago
moneromooo-monero
1a66a86f94
remove unused code
5 years ago
moneromooo-monero
25a7cfdb4a
add a few checks where it seems appropriate
5 years ago
moneromooo-monero
b4ca72dde9
wallet2: fix infinite loop picking outputs in corner case
...
If we have fewer outputs available on the chain than what we
require, but the output we're spending already has a ring,
it would loop picking outputs randomly, but never find enough.
Also tune logs for better debugging this kind of thing.
5 years ago
moneromooo-monero
5e0da6fb68
change SSL certificate fingerprint whitelisting from SHA1 to SHA-256
...
SHA1 is too close to bruteforceable
5 years ago
moneromooo-monero
98fb98f93f
wallet_rpc_server: adding missing return on error in set_daemon
5 years ago
moneromooo-monero
9074c0d8cf
wallet_rpc_server: return false on error in set_log_categories
...
Reported by SmajeNz0
5 years ago
moneromooo-monero
968848a77b
wallet_rpc_server: fix crash in validate_address if no wallet is loaded
...
Reported by SmajeNz0
5 years ago
moneromooo-monero
0eb0d6b802
rpc: improve get_output_distribution
...
It can now handle small reorgs without having to rescan the
whole blockchain.
Also add a test for it.
5 years ago
Dusan Klinec
0aaf5e2ac8
device/trezor: device sorting and filtering improved
...
- Trezor type detection refactored, T1 disabled (was enabled before which was a bug)
- Sort connected devices by env TREZOR_PATH
- Compatibility with Trezor ecosystem using TREZOR_PATH env var
- Enables to pick particular Trezor to use in GUI as we don't have the multi-device selection yet
- Dump all detected devices to log for better debugging / troubleshooting
5 years ago
Riccardo Spagni
581994b61c
Merge pull request #5486
...
4be18df3
tx_sanity_check: relax uniqueness check a bit (moneromooo-monero)
b386ae57
wallet2: add missing "sanity check failed" reason message (moneromooo-monero)
5 years ago
Riccardo Spagni
2e2ee3d823
Merge pull request #5485
...
c519d1df
wallet2: fix wrong change being recorded in sweep_all (moneromooo-monero)
5 years ago
Riccardo Spagni
2aa7fbd1d6
Merge pull request #5480
...
7af49ef0
daemonizer: add --non-interactive for windows (moneromooo-monero)
5 years ago
Riccardo Spagni
edcb0cfff2
Merge pull request #5477
...
97e1c927
wallet: fix key image computation signaling to the device (Dusan Klinec)
5 years ago
Riccardo Spagni
fd7ed93526
Merge pull request #5470
...
31a9aa83
wallet_rpc_server: add block_height and frozen to incoming_transfers (moneromooo-monero)
5 years ago
moneromooo-monero
28a7d31565
p2p: do not send last_seen timestamp to peers
...
This can be used for fingerprinting and working out the
network topology.
Instead of sending the first N (which are sorted by last
seen time), we sent a random subset of the first N+N/5,
which ensures reasonably recent peers are used, while
preventing repeated calls from deducing new entries are
peers the target node just connected to.
The list is also randomly shuffled so the original set of
timestamps cannot be approximated.
5 years ago
moneromooo-monero
64983fcee4
wallet2: default to trying to keep 5 outputs of 2+ monero
...
In the case where previously a second unneeded output would be
added to a transaction. This should help *some* of the cases
where outputs are slowly being consolidated, leading to the
whole balance being locked when sending monero.
5 years ago
moneromooo-monero
df83ed74e4
consensus: from v12, enforce >= 2 outputs
5 years ago
moneromooo-monero
4be18df32a
tx_sanity_check: relax uniqueness check a bit
...
It triggers easily on testnet
5 years ago
moneromooo-monero
b386ae5725
wallet2: add missing "sanity check failed" reason message
5 years ago
moneromooo-monero
c519d1df34
wallet2: fix wrong change being recorded in sweep_all
...
leading to the sanity check triggering
5 years ago
moneromooo-monero
6aa3c2f303
dns_checks: new helper program to check on DNSSEC lookups
5 years ago
moneromooo-monero
7af49ef0c2
daemonizer: add --non-interactive for windows
...
The RPC functional tests need it
Thanks to iDunk for debugging/testing
5 years ago
Dusan Klinec
97e1c9278c
wallet: fix key image computation signaling to the device
5 years ago
moneromooo-monero
31a9aa83af
wallet_rpc_server: add block_height and frozen to incoming_transfers
5 years ago
moneromooo-monero
375fde9454
hardfork: fix off by one updating fork index after popping
5 years ago
Riccardo Spagni
71c6b24893
Merge pull request #5464
...
0f52fe4c
Windows: work around a boost 1.70 and cmake SNAFU (iDunk5400)
b414b69f
Windows: fix a build error in MSYS2 with boost 1.70.0 (iDunk5400)
5 years ago
Riccardo Spagni
2267f110b2
Merge pull request #5463
...
fbbe75d7
device/trezor: button request callback fix (Dusan Klinec)
5 years ago
Riccardo Spagni
950f79dc03
Merge pull request #5389
...
588e6700
simplewallet: fix output representation offset (moneromooo-monero)
35e0a968
wallet2: "output lineup" fake out selection (moneromooo-monero)
5 years ago
Riccardo Spagni
2e342d8df6
Merge pull request #5458
...
84047cb7
wallet_rpc_server: add unlocked field to incoming_transfers output (moneromooo-monero)
5 years ago
Riccardo Spagni
b8f1709684
Merge pull request #5456
...
58eade68
simplewallet: add the change amount to the prompt when locking (moneromooo-monero)
5 years ago
Riccardo Spagni
55807141f2
Merge pull request #5453
...
71102267
wallet_rpc_server: set suggested_confirmations_threshold for pool txes (moneromooo-monero)
5 years ago
Dusan Klinec
fbbe75d75f
device/trezor: button request callback fix
5 years ago
moneromooo-monero
588e670089
simplewallet: fix output representation offset
5 years ago