From f746c9d01b9fe5f8adb69a8f9ef26683c2a5e9e6 Mon Sep 17 00:00:00 2001 From: Thomas Winget Date: Wed, 30 Mar 2016 11:55:54 -0400 Subject: [PATCH] minor corrections/clarifications --- src/cryptonote_core/tx_pool.cpp | 8 +++++--- src/cryptonote_core/tx_pool.h | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/cryptonote_core/tx_pool.cpp b/src/cryptonote_core/tx_pool.cpp index 183c39d9c..49fa4aa57 100644 --- a/src/cryptonote_core/tx_pool.cpp +++ b/src/cryptonote_core/tx_pool.cpp @@ -54,9 +54,11 @@ namespace cryptonote { namespace { - //FIXME: constants such as these should at least be in the header, - // but probably somewhere more accessible to the rest of the - // codebase. + //TODO: constants such as these should at least be in the header, + // but probably somewhere more accessible to the rest of the + // codebase. As it stands, it is at best nontrivial to test + // whether or not changing these parameters (or adding new) + // will work correctly. size_t const TRANSACTION_SIZE_LIMIT_V1 = (((CRYPTONOTE_BLOCK_GRANTED_FULL_REWARD_ZONE_V1 * 125) / 100) - CRYPTONOTE_COINBASE_BLOB_RESERVED_SIZE); size_t const TRANSACTION_SIZE_LIMIT_V2 = (((CRYPTONOTE_BLOCK_GRANTED_FULL_REWARD_ZONE_V2 * 125) / 100) - CRYPTONOTE_COINBASE_BLOB_RESERVED_SIZE); time_t const MIN_RELAY_TIME = (60 * 5); // only start re-relaying transactions after that many seconds diff --git a/src/cryptonote_core/tx_pool.h b/src/cryptonote_core/tx_pool.h index 0ecf90081..84e11eeff 100644 --- a/src/cryptonote_core/tx_pool.h +++ b/src/cryptonote_core/tx_pool.h @@ -448,7 +448,7 @@ namespace cryptonote */ bool is_transaction_ready_to_go(tx_details& txd) const; - //! map a transactions (and related info) to their hashes + //! map transactions (and related info) by their hashes typedef std::unordered_map transactions_container; //TODO: confirm the below comments and investigate whether or not this