blockchain: fix getting invalid block data on failure

6 years ago · d95bc44c6b
parent a9b83f5a6e
commit d95bc44c6b
1 changed files with 2 additions and 1 deletions
--- a/src/cryptonote_core/blockchain.cpp
+++ b/src/cryptonote_core/blockchain.cpp
@ -2217,7 +2217,8 @@ bool Blockchain::find_blockchain_supplement(const std::list<crypto::hash>& qbloc
  CRITICAL_REGION_LOCAL(m_blockchain_lock);

  bool result = find_blockchain_supplement(qblock_ids, resp.m_block_ids, resp.start_height, resp.total_height);
-  resp.cumulative_difficulty = m_db->get_block_cumulative_difficulty(resp.total_height - 1);
+  if (result)
+    resp.cumulative_difficulty = m_db->get_block_cumulative_difficulty(resp.total_height - 1);

  return result;
 }