easylogging++: avoid buffer underflow

7 years ago · c2ed8618e4
parent 187a6ab2d2
commit c2ed8618e4
1 changed files with 3 additions and 2 deletions
--- a/external/easylogging++/easylogging++.cc
+++ b/external/easylogging++/easylogging++.cc
@ -1016,8 +1016,9 @@ const std::string OS::getBashOutput(const char* command) {
  char hBuff[4096];
  if (fgets(hBuff, sizeof(hBuff), proc) != nullptr) {
    pclose(proc);
-    if (hBuff[strlen(hBuff) - 1] == '\n') {
-      hBuff[strlen(hBuff) - 1] = '\0';
+    const size_t len = strlen(hBuff);
+    if (len > 0 && hBuff[len - 1] == '\n') {
+      hBuff[len- 1] = '\0';
    }
    return std::string(hBuff);
  }