From fa3f756bfb4f0595bd2dbe0e22a9d2f00f4a0ef5 Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Mon, 5 Nov 2018 11:15:02 +0000 Subject: [PATCH] unit_tests: fix leak when the test check fails Coverity 189527 --- tests/unit_tests/notify.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit_tests/notify.cpp b/tests/unit_tests/notify.cpp index 4daeeddee..edc4eabdf 100644 --- a/tests/unit_tests/notify.cpp +++ b/tests/unit_tests/notify.cpp @@ -49,7 +49,8 @@ TEST(notify, works) tmp = "/tmp"; static const char *filename = "monero-notify-unit-test-XXXXXX"; const size_t len = strlen(tmp) + 1 + strlen(filename); - char *name_template = (char*)malloc(len + 1); + std::unique_ptr name_template_((char*)malloc(len + 1)); + char *name_template = name_template_.get(); ASSERT_TRUE(name_template != NULL); snprintf(name_template, len + 1, "%s/%s", tmp, filename); int fd = mkstemp(name_template); @@ -75,5 +76,4 @@ TEST(notify, works) ASSERT_TRUE(s == "1111111111111111111111111111111111111111111111111111111111111111"); boost::filesystem::remove(name_template); - free(name_template); }