wallet_rpc_server: do not use RPC data if the call failed

Found by codacy.com
6 years ago · aee7a4e364
parent 1a0733e534
commit aee7a4e364
1 changed files with 2 additions and 1 deletions
--- a/src/wallet/wallet_rpc_server.cpp
+++ b/src/wallet/wallet_rpc_server.cpp
@ -2891,7 +2891,8 @@ namespace tools
    cryptonote::COMMAND_RPC_GET_HEIGHT::response hres;
    hres.height = 0;
    bool r = wal->invoke_http_json("/getheight", hreq, hres);
-    wal->set_refresh_from_block_height(hres.height);
+    if (r)
+      wal->set_refresh_from_block_height(hres.height);
    crypto::secret_key dummy_key;
    try {
      wal->generate(wallet_file, req.password, dummy_key, false, false);