Merge pull request #2246

c34a2b4 QML: fix warnings (selsta)

js/TxUtils.js

@@ -12,13 +12,13 @@ function destinationsToAddress(destinations){
 }
 
 function addressTruncate(address, range){
-    if(typeof(address) === "undefined") return;
+    if(typeof(address) === "undefined") return "";
     if(typeof(range) === "undefined") range = 8;
     return address.substring(0, range) + "..." + address.substring(address.length-range);
 }
 
 function addressTruncatePretty(address, blocks){
-    if(typeof(address) === "undefined") return;
+    if(typeof(address) === "undefined") return "";
     if(typeof(blocks) === "undefined") blocks = 2;
     blocks = blocks <= 1 ? 1 : blocks >= 23 ? 23 : blocks;
     var ret = "";

pages/Keys.qml

@@ -116,11 +116,11 @@ Rectangle {
 
             MoneroComponents.LineEdit {
                 Layout.fillWidth: true
+                id: walletCreationHeight
                 readOnly: true
                 copyButton: true
                 labelText: qsTr("Block #") + translationManager.emptyString
                 fontSize: 16
-                text: currentWallet.walletCreationHeight
             }
         }
 
@@ -261,6 +261,7 @@ Rectangle {
     function onPageCompleted() {
         console.log("keys page loaded");
 
+        walletCreationHeight.text = currentWallet.walletCreationHeight
         secretViewKey.text = currentWallet.secretViewKey
         publicViewKey.text = currentWallet.publicViewKey
         secretSpendKey.text = (!currentWallet.viewOnly) ? currentWallet.secretSpendKey : ""

wizard/WizardCreateWallet1.qml

@@ -151,7 +151,7 @@ Rectangle {
                     labelFontSize: 14
                     copyButton: false
                     readOnly: true
-                    text: Utils.roundDownToNearestThousand(wizardController.m_wallet.walletCreationHeight)
+                    text: Utils.roundDownToNearestThousand(wizardController.m_wallet ? wizardController.m_wallet.walletCreationHeight : 0)
                 }
 
                 MoneroComponents.WarningBox {