From 151f33ba106ece5e5b8c8af4972b875435f82ec7 Mon Sep 17 00:00:00 2001
From: Daniel Karzel <daniel@comit.network>
Date: Mon, 22 Feb 2021 13:43:57 +1100
Subject: [PATCH] Rename variables to add to understanding the code

---
 swap/src/asb/kraken.rs | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/swap/src/asb/kraken.rs b/swap/src/asb/kraken.rs
index 62aa4d4d..4f8e36b0 100644
--- a/swap/src/asb/kraken.rs
+++ b/swap/src/asb/kraken.rs
@@ -66,23 +66,23 @@ impl From<serde_json::Error> for Error {
 
 impl RateService {
     pub async fn new() -> Result<Self> {
-        let (tx, rx) = watch::channel(Err(Error::NotYetRetrieved));
+        let (rate_update, rate_update_receiver) = watch::channel(Err(Error::NotYetRetrieved));
 
-        let (ws, _response) =
+        let (rate_stream, _response) =
             tokio_tungstenite::connect_async(Url::parse(KRAKEN_WS_URL).expect("valid url")).await?;
 
-        let (mut write, mut read) = ws.split();
+        let (mut rate_stream_sink, mut rate_stream) = rate_stream.split();
 
         tokio::spawn(async move {
-            while let Some(msg) = read.next().await {
+            while let Some(msg) = rate_stream.next().await {
                 let msg = match msg {
                     Ok(Message::Text(msg)) => msg,
                     Ok(_) => {
-                        let _ = tx.send(Err(Error::NonTextMessage));
+                        let _ = rate_update.send(Err(Error::NonTextMessage));
                         continue;
                     }
                     Err(e) => {
-                        let _ = tx.send(Err(e.into()));
+                        let _ = rate_update.send(Err(e.into()));
                         continue;
                     }
                 };
@@ -95,7 +95,7 @@ impl RateService {
                 let ticker = match serde_json::from_str::<TickerUpdate>(&msg) {
                     Ok(ticker) => ticker,
                     Err(e) => {
-                        let _ = tx.send(Err(e.into()));
+                        let _ = rate_update.send(Err(e.into()));
                         continue;
                     }
                 };
@@ -103,18 +103,22 @@ impl RateService {
                 let rate = match Rate::try_from(ticker) {
                     Ok(rate) => rate,
                     Err(e) => {
-                        let _ = tx.send(Err(e));
+                        let _ = rate_update.send(Err(e));
                         continue;
                     }
                 };
 
-                let _ = tx.send(Ok(rate));
+                let _ = rate_update.send(Ok(rate));
             }
         });
 
-        write.send(SUBSCRIBE_XMR_BTC_TICKER_PAYLOAD.into()).await?;
+        rate_stream_sink
+            .send(SUBSCRIBE_XMR_BTC_TICKER_PAYLOAD.into())
+            .await?;
 
-        Ok(Self { receiver: rx })
+        Ok(Self {
+            receiver: rate_update_receiver,
+        })
     }
 }