7 Commits (5b19c9a7b7b657a3b1f88f6a2bfa04adfc94abde)

Author	SHA1	Message	Date
ston1th	496055d128	monerod: do not log to tmpdir in daemon mode ... The logging to /tmp/bitmonero.daemon.stdout.stderr caused segfaults if the /tmp mount was full (#2851). Now the daemon is only logging to /tmp/bitmonero.daemon.stdout.stderr in the debug builds.	6 years ago
Erik de Castro Lopo	51efb21713	daemon: Add ability to write a PID file ... The PID file will only be written if the daemon is called with the `--detach` command line argument and a `--pidfile /some/file/path` argument.	7 years ago
Howard Chu	33d17c37e8	Don't hardcode /tmp	7 years ago
redfish	ce6b83128e	daemonizer: posix: keep parent's working dir and umask ... Keep the working directory (and umask) inherited from the parent. Otherwise, it's impossible to control the working directory of the daemon (from systemd, for example). Furthermoer, bitmonerod attempts to create logging directories and files *in current working directory*. This fails due to permission denied and generates a (caught, nonfatal) exception. Below is the strace with this patch applied (so, no `chdir("/")`), showing successful opens at `log/` relative path. Without this patch they fail (sorry, didn't save the trace). ``` 28911 getcwd("/.../bitmonero", 128) = 25 28911 stat64("/var/lib/bitmonero/.bitmonero", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0 28911 stat64("/etc/bitmonerod.conf", {st_mode=S_IFREG|0644, st_size=244, ...}) = 0 28911 open("/etc/bitmonerod.conf", O_RDONLY|O_LARGEFILE) = 3 28911 open("/var/log/bitmonero/bitmonero.log", O_WRONLY|O_CREAT|O_APPEND|O_LARGEFILE, 0666) = 3 28911 stat64("log", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 28911 stat64("log/dbg", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 28911 open("log/dbg/main.log", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = 4 ``` The reasoning of chdir("/") in order to prevent the daemon from holding a filesystem in busy state is not compelling at all: the choice of working directory for the daemon is the user's business not the daemon's.	8 years ago
moneromooo-monero	f7301c3563	Revert "Print stack trace upon exceptions" ... Ain't nobody got time for link/cmake skullduggery. This reverts commit fff238ec94.	8 years ago
moneromooo-monero	fff238ec94	Print stack trace upon exceptions ... Useful for debugging users' logs	8 years ago
Thomas Winget	9193d6fb5b	Daemonize changes pulled in -- daemon builds ... many RPC functions added by the daemonize changes (and related changes on the upstream dev branch that were not merged) were commented out (apart from return). Other than that, this *should* work...at any rate, it builds, and that's something.	9 years ago