Fixed undefined behavior in ROR/ROL

5 years ago · 4cec4db7f0
parent 3b97d399b1
commit 4cec4db7f0
1 changed files with 2 additions and 2 deletions
--- a/src/crypto/variant4_random_math.h
+++ b/src/crypto/variant4_random_math.h
@ -106,13 +106,13 @@ static FORCEINLINE void v4_random_math(const struct V4_Instruction* code, v4_reg
 		case ROR: \
 			{ \
 				const uint32_t shift = src % REG_BITS; \
-				*dst = (*dst >> shift) | (*dst << (REG_BITS - shift)); \
+				*dst = (*dst >> shift) | (*dst << ((REG_BITS - shift) % REG_BITS)); \
 			} \
 			break; \
 		case ROL: \
 			{ \
 				const uint32_t shift = src % REG_BITS; \
-				*dst = (*dst << shift) | (*dst >> (REG_BITS - shift)); \
+				*dst = (*dst << shift) | (*dst >> ((REG_BITS - shift) % REG_BITS)); \
 			} \
 			break; \
 		case XOR: \