dad1077577
Only log an error if fork version is higher AND is not known.
6 years ago
57c0b1ed9f
Fix typos in various files
6 years ago
4f93f74528
Merge pull request #3277
...
0e7ad2e2af773211cc9a0bee55f8d917450306a0#3318 (stoffu)
9f9e095a#3261 (Jean Pierre Dudey)
6 years ago
fbcc91c2a4
Correct spelling mistakes.
6 years ago
af773211cb
Stagenet
6 years ago
ef47ba95c8
Merge pull request #3229
...
928c1825
6 years ago
bdf0339dda
Merge pull request #3181
...
e3f0980a
6 years ago
928c1825f0
cryptonote_protocol: guard against all threads in standby
7 years ago
4fcf609942
Merge pull request #3186
...
7ed62e63
7 years ago
84a7f6a482
Readd copyright starting date
7 years ago
18216f19dd
Update 2018 copyright
7 years ago
7ed62e63e5
cryptonote_protocol: fix std::move usage on different types
7 years ago
d25217f058
Merge pull request #3105
...
b56f4645
7 years ago
5a312752af
Merge pull request #3040
...
69f9a075
7 years ago
75cbb7719e
Merge pull request #3015
...
f06603a4
7 years ago
e3f0980a1d
daemon: don't drop RPC with busy error when running offline
7 years ago
b56f46457c
cryptonote_protocol: fix size_t used in wire format
...
This is 32 bits on 32 bit platforms, but 64 bits on 64 bit platforms.
7 years ago
0b5994fbec
Merge pull request #3004
...
a2c845c7
7 years ago
69f9a07553
cryptonote_protocol: fix missing space in version mismatch message
7 years ago
f06603a439
cryptonote_protocol: update target height when receiving blocks
7 years ago
a2c845c7e3
cryptonote_protocol: internal error consistency size check
7 years ago
b51dc56687
use const refs in for loops for non tiny types
7 years ago
45a1c4c088
add empty container sanity checks when using front() and back()
7 years ago
46d6fa35c9
cryptonote_protocol: sanity check chain hashes from peer
7 years ago
25584f8639
cryptonote_protocol: print peer versions when unexpected
...
also avoid integer underflow on zero height
7 years ago
066fd7aced
Merge pull request #2877
...
43f5269fbb89ae8b4abf25f3
7 years ago
bb89ae8b20
move connection_basic and network_throttle from src/p2p to epee
...
These even had the epee namespace.
This fixes some ugly circular dependencies.
7 years ago
4abf25f3c9
cryptonote_core does not depend on p2p anymore
...
As a followon side effect, this makes a lot of inline code
included only in particular cpp files (and instanciated
when necessary.
7 years ago
09ce03d612
move includes around to lessen overall load
7 years ago
9b511d3e93
Merge pull request #2866
...
cf5f6236
7 years ago
b927f0b17e
cryptonote_protocol: fix corner case looping asking for same block hashes
7 years ago
cf5f623616
Corrections in rate limiting / trottle code, especially in 'out' direction
...
Deleted 3 out of 4 calls to method connection_basic::sleep_before_packet
that were erroneous / superfluous, which enabled the elimination of a
"fudge" factor of 2.1 in connection_basic::set_rate_up_limit;
also ended the multiplying of limit values and numbers of bytes
transferred by 1024 before handing them over to the global throttle
objects
7 years ago
310b790a64
make connection_id a string in RPC
...
It's sent as JSON, so raw binary is not appropriate
7 years ago
383ff4f689
remove "using namespace std" from headers
...
It's nasty, and actually breaks on Solaris, where if.h fails to
build due to:
struct map *if_memmap;
7 years ago
1ff638e927
protocol: drop connections which don't handshake after some time
7 years ago
4d35ad7603
Fix compiler warnings with Clang 6.0.0.
...
monero/src/cryptonote_protocol/block_queue.cpp:208:44: error:
suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
static const boost::uuids::uuid uuid0 = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0};
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{ }
monero/src/wallet/wallet_rpc_server.cpp:1895:43: error:
lambda capture 'wal' is not used [-Werror,-Wunused-lambda-capture]
tools::signal_handler::install([&wrpc, &wal](int) {
^
monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:40: error:
lambda capture 'arg' is not used [-Werror,-Wunused-lambda-capture]
m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
^
monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:46: error:
lambda capture 'fluffy_arg' is not used [-Werror,-Wunused-lambda-capture]
m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
^
monero/src/blockchain_utilities/blockchain_export.cpp:181:3: error:
bool literal returned from 'main' [-Werror,-Wmain]
CHECK_AND_ASSERT_MES(r, false, "Failed to initialize source blockchain storage");
^ ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
expanded from macro 'CHECK_AND_ASSERT_MES'
...fail_ret_val, message) do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
^ ~~~~~~~~~~~~
monero/src/blockchain_utilities/blockchain_export.cpp:195:3: error:
bool literal returned from 'main' [-Werror,-Wmain]
CHECK_AND_ASSERT_MES(r, false, "Failed to export blockchain raw data");
^ ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
expanded from macro 'CHECK_AND_ASSERT_MES'
...fail_ret_val, message) do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
^ ~~~~~~~~~~~~
7 years ago
d5ab55b8d7
Merge pull request #2604
...
0a872798
7 years ago
1e577e8fbf
Merge pull request #2571
...
8028dde7
7 years ago
5ea20d6944
Merge pull request #2469
...
7adceee6
7 years ago
0a872798bc
protocol: kick idle peers by dropping them
...
This is safer, as we don't risk break expectations (eg, requesting
block hashes and then receiving a late set of blocks). Dropping a
connection means another will be attempted in a fresh state.
Also bump the kick timeout to 5 minutes, to ensure we only kick
really idle peers.
7 years ago
8028dde7a6
block_queue: use boost::uuids::nil_uuid where appropriate
7 years ago
5d65a75b69
move checkpoints in a separate library
7 years ago
74c4f1a563
Merge pull request #2460
...
3487d810
7 years ago
13be8115e4
Merge pull request #2458
...
7f2f6ee1
7 years ago
e29282d208
build: auto update version info without manually deleting version.h
7 years ago
7adceee634
precomputed block hashes are now in blocks of N (currently 256)
...
This shaves a lot of space off binaries
7 years ago
3487d81034
cryptonote_protocol: fix needless chain hashes downloads
...
The last known hash was calculated incorrectly, causing
further chain hash downloads to restart from the current
chain. When the block queue has close to 10k blocks waiting,
this causes frequent downloads of 10k more hashes, but
with only the last few hashes actually being useful.
7 years ago
7f2f6ee1c9
protocol: remove hop count on block propagation
...
It is unused, as it was apparently a future optimization,
and it leaks some information (though since pools publish
thei blocks they find, that amount seems small).
7 years ago
6ac61100a1
Add a --fluffy-blocks option to relay blocks as fluffy blocks
...
Defaults to off, but fluffy blocks are forced enabled on testnet
7 years ago
1e57e48342
Merge pull request #2372
...
c867357ace901fcb84fa015e
7 years ago
c867357adc
cryptonote_protocol: error handling on cleanup_handle_incoming_blocks
7 years ago
63d8dddc0a
cryptonote_protocol: remove old spans when received as old blocks
...
fixes getting those in a loop
7 years ago
36b978f50e
Merge pull request #2314
...
c22d22e29a859844
7 years ago
df0cffede0
cryptonote_protocol: warn if we see a higher top version we expect
7 years ago
317ab21a03
cryptonote_protocol: less strict check on top version on connect
...
This allows peers who synced past a fork on the wrong height
to reorg to the right chain after they updated their software
to include the new version.
7 years ago
cc81a37155
cryptonote_protocol: update target height when syncing too
7 years ago
e2ad372b87
cryptonote_protocol: simplify and remove unnecessary casts
7 years ago
727e67cada
cryptonote_protocol: print peer top height along with its version
7 years ago
c22d22e2db
Cleanup test impact of adding safesyncmode() method
7 years ago
70b8c6d77a
cryptonote_protocol: misc fixes to the new sync algorithm
...
Fix sync wedge corner case:
It could happen if a connection went into standby mode, while
it was the one which had requested the next span, and that span
was still waiting for the data, and that peer is not on the
main chain. Other peers can then start asking for that data
again and again, but never get it as only that forked peer does.
And various other fixes
7 years ago
9a859844f4
Toggle SAFE syncmode on and off automatically
...
If monerod is started with default sync mode, set it to SAFE after
synchronization completes. Set it back to FAST if synchronization
restarts (e.g. because another peer has a longer blockchain).
If monerod is started with an explicit sync mode, none of this
automation takes effect.
7 years ago
4466b6d1b0
Merge pull request #2303
...
5a2830787b747607
7 years ago
4859a00134
Merge pull request #2300
...
42b34b35
7 years ago
1d32a5a445
Merge pull request #2291
...
b59cd074
7 years ago
5a283078ec
cryptonote_protocol: large block sync size before v4
7 years ago
7b74760756
cryptonote_protocol: kick idle synchronizing peers
...
In case they dropped off downloading for any reason, they'll get
sent to download again.
7 years ago
42b34b3545
Consistently print peer id in hex and on 16 chars
7 years ago
b59cd0745b
befor -> before
...
Really unique yet consistent spelling mistake
7 years ago
827afcb7ea
protocol: pass blockchain cumulative difficulty when syncing
...
Not used yet.
7 years ago
53dde37ceb
Merge pull request #2276
...
a1891ebe
7 years ago
86cf8cac86
Merge pull request #2275
...
88e83f94
7 years ago
1d093eff67
Merge pull request #2273
...
0e8d60c0
7 years ago
e0df740bc9
Merge pull request #2272
...
f90bbe2a
7 years ago
35e01a6e50
cryptonote_protocol: fix "holes" in block download schedule
7 years ago
3da1edfde5
cryptonote_protocol: fix out of order addition
...
This was broken by the reorg fix, since we now have to add blocks
regardless of their starting height. We now check whether we know
the parent for the first block in the next span, or whether it was
requested. If neither, it's an orphan. If it is not known, but was
requested, we wait to get that block.
7 years ago
6edb1b3e46
block_queue: do not add empty spans
7 years ago
2ec15a6931
daemon: print peers' top height in sync_info
7 years ago
88e83f9427
cryptonote_protocol_handler: log versions as unsigned ints
...
They're interpreted as characters otherwise
7 years ago
08abb670e1
protocol: fix reorgs while syncing
7 years ago
a1891ebea9
tests: fix tests build
...
Add get_fork_version and add_ideal_fork_version to core so
cryptonote_protocol does not have to need the Blockchain
class directly, as it's not in its dependencies, and add
those to the fake core classes in tests too.
7 years ago
0e8d60c06c
cryptonote_protocol: fix recv/send idle time before handshake
7 years ago
f90bbe2a5c
cryptonote_protocol: keep target in sync with dropped connections
...
When a node is dropped, we stop considering its claimed blockchain
height as a factor in the target height calculation. This prevents
a runaway chain from being still thought to be the target even if
the nodes carrying it are dropped.
7 years ago
635929eaca
protocol: add checks for top block hard fork version
...
We won't even talk to a peer which claims a wrong version
for its top block. This will avoid syncing to known bad
peers in the first place.
Also add IP fails when failing to verify a block.
7 years ago
6db8a60a18
Merge pull request #2149
...
158c3ecff57ee38290df52e184e231565be43fcd
7 years ago
b1af32b48d
Merge pull request #2242
...
1c9196b0
7 years ago
ea46a5527a
Merge pull request #2234
...
214fd81e
7 years ago
158c3ecff3
core: thread most of handle_incoming_tx
7 years ago
f57ee382b8
cryptonote_protocol: retry stale spans early
...
Connections can be dropped by the net_node layer,
unbeknownst to cryptonote_protocol, which would then
not flush any spans scheduled to that connection,
which would cause it to be only downloaded again
once it becomes the next span (possibly after a small
delay if it had been requested less than 5 seconds
ago).
7 years ago
90df52e12f
cryptonote_protocol: light cleanup
7 years ago
84e23156ac
cryptonote_protocol: avoid spurious SYNCHRONIZED OK messages
7 years ago
5be43fcdba
cryptonote_protocol_handler: sync speedup
...
A block queue is now placed between block download and
block processing. Blocks are now requested only from one
peer (unless starved).
Includes a new sync_info coommand.
7 years ago
1c9196b0c5
cryptonote_protocol: fix days behind calc on testnet
7 years ago
214fd81e93
some include cleanup
7 years ago
f1b76c8424
cryptonote_protocol: Set send_idle_time in connection_info correctly
7 years ago
8f96cfc20a
Remove typeid use in network_address
...
Since I had to add an ID to the derived classes anyway,
this can be used instead. This removes an apparently
pointless warning from CLANG too.
7 years ago
a0174ad534
Merge pull request #2064
...
6fc2dc39
7 years ago
a237f90c5b
Merge pull request #2052
...
072102cf
7 years ago
6fc2dc3927
cryptonote_protocol_handler: fix crash in debug log
7 years ago
072102cfd2
abstracted nework addresses
...
All code which was using ip and port now uses a new IPv4 object,
subclass of a new network_address class. This will allow easy
addition of I2P addresses later (and also IPv6, etc).
Both old style and new style peer lists are now sent in the P2P
protocol, which is inefficient but allows peers using both
codebases to talk to each other. This will be removed in the
future. No other subclasses than IPv4 exist yet.
7 years ago
b52abd1370
Move txpool to the database
...
Integration could go further (ie, return_tx_to_pool calls should
not be needed anymore, possibly other things).
poolstate.bin is now obsolete.
7 years ago
Thaer Khawaja
Dimitris Apostolou
Riccardo Spagni
Edward Betts
stoffu
moneromooo-monero
xmr-eric
rbrunner7
Vasil Dimov
Howard Chu
Nano Akron