Merge pull request #4906

506472e0 protocol: fix use after free when dropping a connection (moneromooo-monero)
6 years ago · 5ed45acaec
parent 36219feff1 506472e0c6
commit 5ed45acaec
1 changed files with 2 additions and 2 deletions
--- a/src/cryptonote_protocol/cryptonote_protocol_handler.inl
+++ b/src/cryptonote_protocol/cryptonote_protocol_handler.inl
@ -1740,9 +1740,9 @@ skip:
    if (add_fail)
      m_p2p->add_host_fail(context.m_remote_address);

-    m_p2p->drop_connection(context);
-
    m_block_queue.flush_spans(context.m_connection_id, flush_all_spans);
+
+    m_p2p->drop_connection(context);
  }
  //------------------------------------------------------------------------------------------------------------------------
  template<class t_core>