From 85de732ad49a3b4827d02b8c46c98a59f41ef6c6 Mon Sep 17 00:00:00 2001 From: Tony Theodore Date: Mon, 4 Jul 2016 14:26:12 +1000 Subject: [PATCH] fix multiple downloads of same file see #1415 fixes #1079 --- Makefile | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index cd45f8c2..17f844e8 100644 --- a/Makefile +++ b/Makefile @@ -426,7 +426,12 @@ define PKG_RULE download-$(1): $(addprefix download-,$($(1)_DEPS)) download-only-$(1) .PHONY: download-only-$(1) -download-only-$(1): +# Packages can share a source archive to build different sets of features +# or dependencies (see bfd/binutils openscenegraph/openthreads qwt/qwt_qt4). +# Use a double-colon rule to allow multiple definitions: +# https://www.gnu.org/software/make/manual/html_node/Double_002dColon.html +download-only-$(1): download-only-$($(1)_FILE) +download-only-$($(1)_FILE):: $(and $($(1)_URL), @[ -d '$(LOG_DIR)/$(TIMESTAMP)' ] || mkdir -p '$(LOG_DIR)/$(TIMESTAMP)' @if ! $(call CHECK_PKG_ARCHIVE,$(1)); then \