From 998c56fb0ef63bf9206ae5d5ec8df6c7c7d15e6c Mon Sep 17 00:00:00 2001 From: moneroexamples Date: Sun, 4 Nov 2018 17:27:59 +0800 Subject: [PATCH] better error handling when submitting tx --- html/js/controllers/send_coins.js | 7 +++++++ src/YourMoneroRequests.cpp | 12 ++++++++++++ 2 files changed, 19 insertions(+) diff --git a/html/js/controllers/send_coins.js b/html/js/controllers/send_coins.js index 22a2134..43f535b 100644 --- a/html/js/controllers/send_coins.js +++ b/html/js/controllers/send_coins.js @@ -179,6 +179,13 @@ class HostedMoneroAPIClient self.$http.post(config.apiUrl + endpointPath, parameters).then( function(data) { + if (data.data.error) + { + const errStr = "Invalid mixin - must be >= 0"; + const err = new Error(data.data.error); + fn(err); + return; + } __proceedTo_parseAndCallBack(data.data) } ).catch( diff --git a/src/YourMoneroRequests.cpp b/src/YourMoneroRequests.cpp index 5be2a50..cbf21e2 100755 --- a/src/YourMoneroRequests.cpp +++ b/src/YourMoneroRequests.cpp @@ -910,6 +910,9 @@ YourMoneroRequests::submit_raw_tx( { j_response["status"] = "error"; j_response["error"] = "Tx faild parse_hexstr_to_binbuff"; + + OMERROR << j_response["error"]; + session_close(session, j_response.dump()); return; } @@ -920,6 +923,9 @@ YourMoneroRequests::submit_raw_tx( { j_response["status"] = "error"; j_response["error"] = "Tx faild parse_and_validate_tx_from_blob"; + + OMERROR << j_response["error"]; + session_close(session, j_response.dump()); return; } @@ -931,6 +937,9 @@ YourMoneroRequests::submit_raw_tx( "in the mempool. " "Please wait till your previous tx(s) " "get mined"; + + OMERROR << j_response["error"]; + session_close(session, j_response.dump()); return; } @@ -941,6 +950,9 @@ YourMoneroRequests::submit_raw_tx( { j_response["status"] = "error"; j_response["error"] = error_msg; + + OMERROR << j_response["error"]; + session_close(session, j_response.dump()); return; }