Paul Shapiro
3b7cc01878
monero_transfer_utils: not throwing invalid pid for empty pid str
5 years ago
Guten Ye
58ada5b4c4
Keep dust utxo if mixable, no matter sweeping or not
5 years ago
Paul Shapiro
365f4a1a5c
added fee_mask support
5 years ago
Paul Shapiro
966f137d30
fixed pre-rct out .rct field empty detection
5 years ago
Paul Shapiro
707416165b
ndorf: Pass ptree by const ref
...
ndorf: Pass payment id string by const ref
ndorf: Pass addr/key strings as movable temporaries
ndorf: Construct istringstream directly from string
ndorf: Move push/popped vector elements instead of copying
ndorf: Use unidirectional stringstreams
ndorf: Eliminate a needless copy of ptree child (not movable)
ndorf: Remove redundant move() on rvalues returned from function
ndorf: Remove move() on ptree nodes, it's not supported anyway
ndorf: Use unidirectional stringstreams (added istream which was left out at the time)
6 years ago
Paul Shapiro
399d3fadf1
Implemented async monero send routine
6 years ago
Paul Shapiro
41fbc55521
added bridge__mainnet_pubKeyDerivations test case to verify output ownership in generated txs; monero_transfer_utils / serial_bridge_index: exposed tx_pub_key retVal .. one possible addtl retVal would be the output pub keys.. but is there a use in non-test envs for that data?
6 years ago
Paul Shapiro
13b943d580
integrating openmonero's fix for mymonero-app-js#240 for spending rct coinbase outs
6 years ago
Paul Shapiro
6f11fff141
monero_transfer_utils: minor comment clarifications, formatting, and checking (basically impossible) err retval from _rct_hex_to_decrypted_mask; test_all: added stagenet coinbase outputs send test
6 years ago
Paul Shapiro
aea00b3108
monero_transfers_utils removed unused line that caused extra copy
6 years ago
Paul Shapiro
ee3eede5d2
send step2 clarified arg sending_amount as final_total_wo_fee
6 years ago
Paul Shapiro
9ed97d0902
commented some new logs - it would be nice to enable these later
6 years ago
Paul Shapiro
8c81237303
send: tweaked step2 name
6 years ago
Paul Shapiro
617659c707
fixed bug when sending to subaddrs - cryptonote_tx_utils takes a list of tx_destination_entrys which it assumes have got their is_subaddr flags set correctly - and the flag that the to-address is a subaddress didn't get ported from cn_utils construct/create tx because we didn't need to do it in core-js to add subaddr support there – given that in core-js we modified the pub key for subaddr sending by directly detecting whether the dst addr is a subaddr – a difference from cryptonote_tx_utils. funds that were sent using the faulty subaddr support are not lost and are recoverable because only the tx pub key of the txs was incorrectly written - if the correct tx pub key is generated and use for that tx then funds can be scanned and sent from the correct receiving wallet - mymonero-app-js#237
6 years ago
Paul Shapiro
a9daf4cef9
ported of send_coins.js / SendFunds() to C++, incl initial block weight support (previous commit already updated fee); set a few 'rct' lookups from get() to get_optional() in serial bridge (likely bugfix for pre rct outs - probably was the cause of some exceptions); returning tx and txBlob_byteLength from convenience__create_transaction for send fns; removed now unnecessary calculate_fee, estimate_rct_tx_size, create_transaction from bridge (encapsulated in send routine).. switched estimated_tx_network_fee over to fee_per_b (API change - the app-side bridge will take fee_per_kb with optl fee_per_b, preferring the latter and converting the former to b by /= 1024
6 years ago
Paul Shapiro
bb9e55d4fe
initial fee updates for block weight based tx construction; moved some functions around (+monero_fee_utils)
6 years ago
Paul Shapiro
69d69634fc
updated to 0.13.0.3
6 years ago
Paul Shapiro
3d81b96812
updating fixed_ringsize from 7 to 11
6 years ago
Paul Shapiro
95f140f373
some cleanups per feedback
6 years ago
Paul Shapiro
a2c1036ef2
create_transaction: checking output amount overflow before addition
6 years ago
Paul Shapiro
37d01a885e
added missing to_addr to prev commit's dsts (regression - funds didn't appear at target)
6 years ago
Paul Shapiro
08edc0bd58
modified the interface to create transactions to remove requirement to construct and send dsts with either change or fake dst, by exposing change amount as param and uncommenting kept change addr / dsts construction - which actually solves a tx not created bug when sending to an addr (who is not oneself) with a short pid
6 years ago
Paul Shapiro
9a9d9cb8f0
added tx_key to create_transaction ret vals
6 years ago
Paul Shapiro
05147ea986
fee fns
6 years ago
Paul Shapiro
2ea3a47d85
added serial_bridge_index with JSON-bridged create tx, with new convenience create_transaction fn for extra construction etc, plus test
6 years ago
Paul Shapiro
e599578273
implemented monero_transfer_utils::create_transaction
6 years ago
Paul Shapiro
b72ebdcb04
added monero fork rules, migrated use_fork_rules_fn_type decl to it, added fee est convenience fn and fee test
6 years ago
Paul Shapiro
423aff433e
some minor fixes and updates to parsing fns in monero_transfer_utils
6 years ago
Paul Shapiro
8a6f3166ba
fix to last commit to compile
6 years ago
Paul Shapiro
22bb35bf01
key img nad monero tfer utils (w/o construct tx port yet) compiling w monero src update
6 years ago