removed new_fake_address_for_rct_tx as it's already in create_transaction

README.md

@@ -161,12 +161,6 @@ In future, the key names could be compressed.
 
 * Returns: `err_msg: String` *OR* `retVal: String`
 
-**`new_fake_address_for_rct_tx`**
-
-* Args: `nettype_string: NettypeString`
-
-* Returns: `err_msg: String` *OR* `retVal: String`
-
 **`new_payment_id`**
 
 * Args: *empty object*

src/monero_address_utils.cpp

@@ -124,14 +124,3 @@ optional<string> address_utils::new_integratedAddrFromStdAddr(const string &std_
 	);
 	return int_address_string;
 }
-account_public_address address_utils::new_fake_address_for_rct_tx()
-{
-	cryptonote::account_base dummy;
-	dummy.generate();
-	//
-	return dummy.get_keys().m_account_address;
-}
-string address_utils::new_fake_address_string_for_rct_tx(network_type nettype)
-{
-	return get_account_address_as_str(nettype, false/*subaddress*/, new_fake_address_for_rct_tx());
-}

src/monero_address_utils.hpp

@@ -58,8 +58,5 @@ namespace monero
 		bool isIntegratedAddress(const string &addressString, network_type nettype);
 		//
 		optional<string> new_integratedAddrFromStdAddr(const string &std_address_string, const string &short_paymentID, cryptonote::network_type nettype);
-		//
-		account_public_address new_fake_address_for_rct_tx();
-		string new_fake_address_string_for_rct_tx(network_type nettype);
 	}
 }

src/serial_bridge_index.cpp

@@ -197,23 +197,6 @@ string serial_bridge::new_integrated_address(const string &args_string)
 	//
 	return ret_json_from_root(root);
 }
-string serial_bridge::new_fake_address_for_rct_tx(const string &args_string)
-{
-	boost::property_tree::ptree json_root;
-	if (!parsed_json_root(args_string, json_root)) {
-		// it will already have thrown an exception
-		return error_ret_json_from_message("Invalid JSON");
-	}
-	optional<string> retVal = monero::address_utils::new_fake_address_string_for_rct_tx(
-		nettype_from_string(json_root.get<string>("nettype_string"))
-	);
-	boost::property_tree::ptree root;
-	if (retVal != none) {
-		root.put(ret_json_key__generic_retVal(), std::move(*retVal));
-	}
-	//
-	return ret_json_from_root(root);
-}
 string serial_bridge::new_payment_id(const string &args_string)
 {
 	boost::property_tree::ptree json_root;

src/serial_bridge_index.hpp

@@ -49,7 +49,6 @@ namespace serial_bridge
 	string is_integrated_address(const string &args_string);
 	//
 	string new_integrated_address(const string &args_string);
-	string new_fake_address_for_rct_tx(const string &args_string);
 	string new_payment_id(const string &args_string);
 	//
 	string newly_created_wallet(const string &args_string);

test/test_all.cpp

@@ -544,28 +544,6 @@ BOOST_AUTO_TEST_CASE(bridged__new_integrated_address)
 	cout << "bridged__new_integrated_address: " << *value << endl;
 }
 //
-BOOST_AUTO_TEST_CASE(bridged__new_fake_address_for_rct_tx)
-{
-	using namespace serial_bridge;
-	//
-	boost::property_tree::ptree root;
-	root.put("nettype_string", string_from_nettype(MAINNET));
-	//
-	auto ret_string = serial_bridge::new_fake_address_for_rct_tx(args_string_from_root(root));
-	stringstream ret_stream;
-	ret_stream << ret_string;
-	boost::property_tree::ptree ret_tree;
-	boost::property_tree::read_json(ret_stream, ret_tree);
-	optional<string> err_string = ret_tree.get_optional<string>(ret_json_key__any__err_msg());
-	if (err_string != none) {
-		BOOST_REQUIRE_MESSAGE(false, *err_string);
-	}
-	optional<string> value = ret_tree.get_optional<string>(ret_json_key__generic_retVal());
-	BOOST_REQUIRE(value != none);
-	BOOST_REQUIRE((*value).size() > 0);
-	cout << "bridged__new_fake_address_for_rct_tx: " << *value << endl;
-}
-//
 BOOST_AUTO_TEST_CASE(bridged__new_short_payment_id)
 {
 	using namespace serial_bridge;