From 6b4bc0d389596bb5d3da1c1388e0c6c28ecfda63 Mon Sep 17 00:00:00 2001 From: binaryFate Date: Sat, 28 Sep 2019 19:22:15 +0200 Subject: [PATCH] RPC on_transfer_split error consistent with on_transfer if no tx sent --- src/wallet/wallet_rpc_server.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/wallet/wallet_rpc_server.cpp b/src/wallet/wallet_rpc_server.cpp index 0e0221c03..2ca746cfe 100644 --- a/src/wallet/wallet_rpc_server.cpp +++ b/src/wallet/wallet_rpc_server.cpp @@ -1003,6 +1003,13 @@ namespace tools std::vector ptx_vector = m_wallet->create_transactions_2(dsts, mixin, req.unlock_time, priority, extra, req.account_index, req.subaddr_indices); LOG_PRINT_L2("on_transfer_split called create_transactions_2"); + if (ptx_vector.empty()) + { + er.code = WALLET_RPC_ERROR_CODE_TX_NOT_POSSIBLE; + er.message = "No transaction created"; + return false; + } + return fill_response(ptx_vector, req.get_tx_keys, res.tx_key_list, res.amount_list, res.fee_list, res.multisig_txset, res.unsigned_txset, req.do_not_relay, res.tx_hash_list, req.get_tx_hex, res.tx_blob_list, req.get_tx_metadata, res.tx_metadata_list, er); }